From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id C5F29385803B for ; Fri, 16 Feb 2024 18:20:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C5F29385803B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C5F29385803B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::530 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708107603; cv=none; b=bTGRqV7WIhUPpRDHm0/u1oKL5BhFmKr4LTCty39nMuALz+EsCp2WOrfBaO5c1C/hXuuRKg/+tc9deZ/EI1K7C3cWlWt7DUD/zdSgAOjZXhMW+gFztVUJT/VNXnhoBd8Qsf3iCapnEVEWG7YK80Th371oO+0GNHyExb4WXSdgknM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708107603; c=relaxed/simple; bh=W3TYu0nxUa1rdVMvrX80CTHY27KjldbOAflyQPwwC4Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=THZBdUa8bj+Z/kkaW1sdtyciMH0CZc2G17KWawI0R9JpnAc0pnNUjVd0MXTmm3UMvoQIbCIZNJdTZZeJueKkj62NrDe221QIxprUqRqojt9r7xLbvhqrJyQ6y0p1rCjAAPIB3xZdqQQt+kCfSf0xkZCeb5rlOAVcHLSocwh1WzY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-5d8b519e438so2182576a12.1 for ; Fri, 16 Feb 2024 10:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1708107600; x=1708712400; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Za2GemlJpUzyms5jkL1vpe1CstgfN+PtVah4VT7OyBo=; b=bfVinKzu7i6U8Su36ZbPjM3NLmJX6jo2clKRkarpu9S2C+EDiO1fh4mPj4rZXJzDOR hmPDR8xf9CY6eWaryaJaX0RtDbW1Ngy8Wlnbzf5YRN5jSYGwhzecAli3QkYGkgyxJMcJ WEo2S0ubdWo56hov+Awp39x7ZYDcGFo5QCbwv49+0MSOCYtdkIVsiwMeT98c7IcRFwlL Bz4znPveDbRbBVK4n7hylV5hAtSD2A209Q0z+f3AMla2nIM+x2pgQ3mmZF15WEfnHg5E QUpHGOkDiLeUbnzIie/FaxR3AYQeYzfkyEbNCCc4qCLAlF6g9Tohe7/j7S8C7w0Cqxgx uXmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708107600; x=1708712400; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Za2GemlJpUzyms5jkL1vpe1CstgfN+PtVah4VT7OyBo=; b=Q2XswuQedRXdVxr4HG2svXniYum640DuyCFkAXPl1IR4oA3b+rOj05CAXSR2bGorkS HnDNXcqXLqjJhKMnLpW2809mzCjy4CM9EFadxe2haLX0L1MmyaZppR5xqo3R+/hiMMuS XNx0E0x43ihaE9OLclCmOiQvzJCAnsB8RezEXNN88aBXOQgF92CZEH9V+U0Ko0PZs1cA /6Y6BcgaZUWBzXUqdHtS3GGlch7vyh+0rH3/3cloxFM6pu2TyZ1XAo0rd5HoMNYFiJHb Dyw7edMWiueJf4Tp0SJgZCucDvMhmX2vCgqmgTzHu1qrEx40NjR7+rEnxR0wGaZ7peWO d0PA== X-Gm-Message-State: AOJu0Yxz3Cx6q27cwF0s5cCWa9I7/0tHhoi5DDsHBK5xzT6boy8p/214 Qf2Xqlq666lawXQNktzmAGBYjUcUyS9hcvZHi+y2MUvChU2/fU2OpZ8PwXxC3i8= X-Google-Smtp-Source: AGHT+IFXx36nCFJdRADKsd36R4YJ08K9qaoYig7Apul22i80ENHfrYU3dtKHVixhy5IuoT6TWwo5NQ== X-Received: by 2002:a17:90b:3754:b0:299:3c22:a86e with SMTP id ne20-20020a17090b375400b002993c22a86emr1712176pjb.9.1708107599781; Fri, 16 Feb 2024 10:19:59 -0800 (PST) Received: from [10.0.17.83] ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id nd4-20020a17090b4cc400b00298d2182f1asm303404pjb.55.2024.02.16.10.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Feb 2024 10:19:59 -0800 (PST) Message-ID: Date: Fri, 16 Feb 2024 10:19:59 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Committed] testsuite: Add support for scanning assembly with comparitor Content-Language: en-US To: Mike Stump Cc: GCC Patches , gnu-toolchain@rivosinc.com References: <20240212193815.3771167-1-ewlu@rivosinc.com> From: Edwin Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks! Committed Edwin On 2/15/2024 9:27 AM, Mike Stump wrote: > On Feb 12, 2024, at 11:38 AM, Edwin Lu wrote: >> There is currently no support for matching at least x lines of assembly >> (only scan-assembler-times). This patch would allow setting upper or lower >> bounds. >> >> Use case: using different scheduler descriptions and/or cost models will change >> assembler output. Testing common functionality across tunes would require a >> separate testcase per tune since each assembly output would be different. If we >> know a base number of lines should appear across all tunes (i.e. testing return >> values: we expect at minimum n stores into register x), we can lower-bound the >> test to search for scan-assembler-bound {RE for storing into register x} >= n. >> This avoids artificially inflating the scan-assembler-times expected count due >> to the assembler choosing to perform extra stores into register x (using it as >> a temporary register). >> >> The testcase would be more robust to cpu/tune changes at the cost of not being >> as granular towards specific cpu tuning. > I didn't see an Ok? Just in case you forgot, yes, this is ok.