Re: [PATCH 0/4] drop version checks for in-tree gas [PR91602]

[Jeff Law <jeffreyalaw@gmail.com>]

On 7/20/2021 9:44 AM, Serge Belyshev wrote:
> Special-casing checks for in-tree gas features is unnecessary since
> r100007 which made configure-gcc depend on all-gas, and thus making
> alternate code path in gcc_GAS_CHECK_FEATURE for in-tree gas
> redundant.
>
> Along the way this fixes PR 91602, which is caused by incorrect guess
> of leb128 support presense in RISC-V.
>
> First patch removes alternate code path in gcc_GAS_CHECK_FEATURE and
> related code, the rest are further cleanups.  Patches 2 and 3 in
> series make no functional changes, thus configure is unchanged.
>
> Bootstrapped/regtested on x86_64-pc-linux-gnu, riscv64-unknown-linux-gnu,
> sparc-sun-solaris2.11 and powerpc-ibm-aix7.{1.5.0,2.4.0}, with and without
> in-tree binutils (except on aix where combined tree does not appear to work
> due to dynamic linker peculiarity).
>
> OK for mainline ?
>
> Serge Belyshev (4):
>    configure: drop version checks for in-tree gas [PR91602]
>    configure: remove version argument from gcc_GAS_CHECK_FEATURE
>    configure: fixup formatting from previous change
>    configure: remove gas versions from tls check
So just be clear, the point here is to stop checking the version # and 
instead always do a real feature check by testing the behavior of the 
assembler, even an in-tree assembler, right?

Jeff