From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Patrick Palka <ppalka@redhat.com>
Subject: Re: [PATCH] c++: Fix up VEC_INIT_EXPR gimplification after r12-7069
Date: Tue, 2 May 2023 14:36:15 -0400 [thread overview]
Message-ID: <ad7973ce-31e1-5aa0-d5b2-0637d896d639@redhat.com> (raw)
In-Reply-To: <ZFEp73Ks9fKJ0tiW@tucnak>
On 5/2/23 11:19, Jakub Jelinek wrote:
> Hi!
>
> During patch backporting, I've noticed that while most cp_walk_tree calls
> with cp_fold_r callback callers were changed from &pset to cp_fold_data
> &data, the VEC_INIT_EXPR gimplifications has not, so it still passes just
> address of a hash_set<tree> and so if during the folding we ever touch
> data->flags, we use uninitialized data there.
>
> The following patch changes it to do the same thing as cp_fold_function
> because the VEC_INIT_EXPR gimplifications will happen on function bodies
> only.
>
> Ok for trunk if it passes bootstrap/regtest?
OK.
> 2023-05-02 Jakub Jelinek <jakub@redhat.com>
>
> * cp-gimplify.cc (cp_fold_data): Move definition earlier.
> (cp_gimplify_expr): Pass address of ff_genericize | ff_mce_false
> constructed data rather than &pset to cp_walk_tree with cp_fold_r.
>
> --- gcc/cp/cp-gimplify.cc.jj 2023-03-16 22:01:02.295090975 +0100
> +++ gcc/cp/cp-gimplify.cc 2023-05-02 17:05:03.079652427 +0200
> @@ -57,6 +57,13 @@ enum fold_flags {
>
> using fold_flags_t = int;
>
> +struct cp_fold_data
> +{
> + hash_set<tree> pset;
> + fold_flags_t flags;
> + cp_fold_data (fold_flags_t flags): flags (flags) {}
> +};
> +
> /* Forward declarations. */
>
> static tree cp_genericize_r (tree *, int *, void *);
> @@ -505,8 +512,8 @@ cp_gimplify_expr (tree *expr_p, gimple_s
> *expr_p = expand_vec_init_expr (NULL_TREE, *expr_p,
> tf_warning_or_error);
>
> - hash_set<tree> pset;
> - cp_walk_tree (expr_p, cp_fold_r, &pset, NULL);
> + cp_fold_data data (ff_genericize | ff_mce_false);
> + cp_walk_tree (expr_p, cp_fold_r, &data, NULL);
> cp_genericize_tree (expr_p, false);
> copy_if_shared (expr_p);
> ret = GS_OK;
> @@ -1029,13 +1036,6 @@ struct cp_genericize_data
> in fold-const, we need to perform this before transformation to
> GIMPLE-form. */
>
> -struct cp_fold_data
> -{
> - hash_set<tree> pset;
> - fold_flags_t flags;
> - cp_fold_data (fold_flags_t flags): flags (flags) {}
> -};
> -
> static tree
> cp_fold_r (tree *stmt_p, int *walk_subtrees, void *data_)
> {
>
> Jakub
>
prev parent reply other threads:[~2023-05-02 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 15:19 Jakub Jelinek
2023-05-02 18:36 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7973ce-31e1-5aa0-d5b2-0637d896d639@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).