From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19727 invoked by alias); 1 Aug 2018 16:34:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19716 invoked by uid 89); 1 Aug 2018 16:34:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=ongoing, undoing, activity, company X-HELO: mail-qt0-f180.google.com Received: from mail-qt0-f180.google.com (HELO mail-qt0-f180.google.com) (209.85.216.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Aug 2018 16:34:09 +0000 Received: by mail-qt0-f180.google.com with SMTP id n6-v6so20583073qtl.4 for ; Wed, 01 Aug 2018 09:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=eIx1YlkKq5J4LnUaFjWxMbcTDZwmvauUTWK0P5sZgDs=; b=O72bLci9Pvi6RWlC9hVdOwFgECG2UeVJ30+36y93coz986zDWxSAmVzgiOdC3w13Bh sHqtkPNTD81mMMtA/azxmjB/5hN11Rl4bq82D9nez+DX24Er4sGVLAXVvbATtg3GmpZR mlClcREpomOZsgdZql4PIW3RCTDyYoB8KKcEXW5AZSA0zCPQjtiNNb3zK5Ra7lSClBn2 mv6nB93ZvFyU039jB3DC4j6PgY2nvMDXjZ+qBpuuxssU9p7KfHTsU+ka19nO59ly+TQb MNgce3Sq/5shlNiOmbthw4Re59W1O/cBzse4bNRAzeHbYLMeeE2cFwEJaJYMQlLkfxNq cbrg== Return-Path: Received: from localhost.localdomain (97-118-124-30.hlrn.qwest.net. [97.118.124.30]) by smtp.gmail.com with ESMTPSA id n36-v6sm13738532qtb.39.2018.08.01.09.34.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Aug 2018 09:34:06 -0700 (PDT) Subject: Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552) To: Bernd Edlinger , "gcc-patches@gcc.gnu.org" References: <0b956fc9-8c11-8e45-903b-46fb8d455c56@gmail.com> From: Martin Sebor Message-ID: Date: Wed, 01 Aug 2018 16:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00118.txt.bz2 >> If you care about detecting bugs I would expect you to be >> supportive rather than dismissive of this work, and helpful >> in bringing it to fruition rather that putting it down or >> questioning my priorities. Especially since the work was >> prompted by your own (valid) complaint that GCC doesn't >> diagnose them. >> > > You don't really listen to what I am saying, I did not say > that we need another warning instead of fixing the wrong > optimization issue at hand. > > But I am in good company, you don't listen to Jakub and Richi > either. I certainly intend to fix bugs I'm responsible for introducing. I always do if given the chance. I assume you are referring to bug 86711 (and 86714). Fixing the underlying problem has been on my mind since you first mentioned it, and on my to-do list since last week (bug 86688). You have now submitted a patch for both of the former, plus a follow-on patch, but you didn't assign either of the bugs to yourself, or indicated if the patch fixes 86688, or if you intend to work on it too. I haven't reviewed the patches in any detail except to note that they touch the same area as mine and likely conflict. I'm not sure what I should do now. Work on fixing these bugs myself? (I would prefer to.) Try to rebase my work on top of yours to see what the conflicts are and try to resolve them them in my ongoing work? Or just keep working on my stuff and deal with the conflicts after your patches have been committed? Or continue to debate conflicting priorities and try to resolve them first? (Those are mostly rhetorical questions.) The point is that if you would just let me fix my bugs we would not have this conundrum. Your test cases are helpful. But as I have said over and over, submitting patches for the same code at the same time and even undoing some prior work with no coordination is a recipe for confusion and conflict. I don't recall this happening in the past and I don't really understand what triggered it in this case. This isn't an area that normally sees a lot of activity. Martin