From: Robin Dapp <rdapp.gcc@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>,
pan2.li@intel.com, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai,
yanzhang.wang@intel.com, kito.cheng@gmail.com
Subject: Re: [PATCH v1] RISC-V: Bugfix for scalar move with merged operand
Date: Mon, 18 Sep 2023 12:00:46 +0200 [thread overview]
Message-ID: <adc2a389-9447-f4a3-908b-ac2dbc476d76@gmail.com> (raw)
In-Reply-To: <db576545-1177-4999-abba-8c4255bf1d58@gmail.com>
> I must be missing something. Doesn't insn 10 broadcast the immediate
> 0x2 to both elements of r142?!? What am I missing?
It is indeed a bit misleading. The difference is in the mask which
is not displayed in the short form. So we actually use a vec_dup
for a single-element move, essentially a masked vec_dup where only
one element is masked in.
The problem was that the original doesn't use a merging "vec_set"
but a "destructive" one where the other elements get ignored.
The fix is OK IMHO.
Regards
Robin
next prev parent reply other threads:[~2023-09-18 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 7:42 pan2.li
2023-09-17 15:52 ` Jeff Law
2023-09-18 1:34 ` Li, Pan2
2023-09-18 10:00 ` Robin Dapp [this message]
2023-09-18 10:24 ` Li, Pan2
2023-09-18 17:44 ` Jeff Law
2023-09-18 23:03 ` Li, Pan2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc2a389-9447-f4a3-908b-ac2dbc476d76@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=pan2.li@intel.com \
--cc=yanzhang.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).