From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 1F5CB3858428 for ; Fri, 3 Dec 2021 03:01:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F5CB3858428 Received: by mail-pj1-x1032.google.com with SMTP id j6-20020a17090a588600b001a78a5ce46aso4097820pji.0 for ; Thu, 02 Dec 2021 19:01:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=k4rtVQQ55FC2GoCU32KSZMblky+M++K5T/n5m8JtAm8=; b=QdHv5TiFZzCQ6m3dgDu46HBaVvOO8o1WmxMZPXINGDnv7vxeqYxMW85SKOmJ/CuG5m Rb84wKaKeZaUxDLO3da6KX+NOswaNEsa+ImbL/1O0a5LI6JSW9GslLfVPqbNSWLAsMY1 QqhXf7oZG4N084XAGE6nzcUm7BBQ51zg9udV8Nq52bneVsrE3F7s14y6M5Gw7EOdqdEn UM4vzpRF3XvloW3qGPhR3uyx959787iy5OUEYYcVSgkT9Hj9vqszY29R46O9CVUiZS78 XPOJ7NGSwZPpgiQ7JmzYInTUafWcmVepqjPagGMEohQgq6pHvJElsT/EH3mdxvIQScft qn2Q== X-Gm-Message-State: AOAM531i3BYFeiHjMQaIJ4iOm/Zmh9+VH/C0kJNjCjb6Hk9C6RnfWQpR hxvuXaMOXUJq+lkNwf6aQoc= X-Google-Smtp-Source: ABdhPJzexJz6ImLW7dQep2FNPHUTpdms7Mh7L9UfIyd7RIMRYhxOEqM9KiC23fJZivUmd6/ATH6k6g== X-Received: by 2002:a17:902:e741:b0:141:f9a7:4995 with SMTP id p1-20020a170902e74100b00141f9a74995mr19464420plf.49.1638500477077; Thu, 02 Dec 2021 19:01:17 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id m184sm807535pga.61.2021.12.02.19.01.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 19:01:16 -0800 (PST) Message-ID: Date: Thu, 2 Dec 2021 20:01:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 2/5] gcc: Fix "argument list too long" from install-plugins Content-Language: en-US To: Richard Purdie , gcc-patches@gcc.gnu.org References: <20211027200505.3340725-1-richard.purdie@linuxfoundation.org> <20211027200505.3340725-3-richard.purdie@linuxfoundation.org> From: Jeff Law In-Reply-To: <20211027200505.3340725-3-richard.purdie@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 03:01:19 -0000 On 10/27/2021 2:05 PM, Richard Purdie via Gcc-patches wrote: > When building in longer build paths (200+ characters), the > "echo $(PLUGIN_HEADERS)" from the install-plugins target would cause an > "argument list too long error" on some systems. > > Avoid this by calling make's sort function on the list which removes > duplicates and stops the overflow from reaching the echo command. > The original sort is left to handle the the .h and .def files. > > 2021-10-26 Richard Purdie > > gcc/ChangeLog: > > * Makefile.in: Fix "argument list too long" from install-plugins > > Signed-off-by: Richard Purdie Thanks.  I've pushed this to the trunk.  Sorry about the long wait. jeff