From: Marco Poletti <poletti.marco@gmail.com>
To: Gabriel Dos Reis <gdr@integrable-solutions.net>
Cc: Shujing Zhao <pearly.zhao@oracle.com>,
Jakub Jelinek <jakub@redhat.com>,
Paolo Bonzini <bonzini@gnu.org>,
"Joseph S. Myers" <joseph@codesourcery.com>,
gcc-patches@gcc.gnu.org,
Paolo Carlini <paolo.carlini@oracle.com>
Subject: Re: gcc/cp/pt.c: use ngettext() when needed
Date: Fri, 26 Feb 2010 07:31:00 -0000 [thread overview]
Message-ID: <ae2276fe1002252313w3d435534ge5f22627b898225a@mail.gmail.com> (raw)
In-Reply-To: <206fcf961002252308t3883270bpb5d7cd0fd02bf2d@mail.gmail.com>
2010/2/26 Gabriel Dos Reis <gdr@integrable-solutions.net>:
> On Tue, Feb 23, 2010 at 10:07 PM, Shujing Zhao <pearly.zhao@oracle.com> wrote:
>> On 02/22/2010 05:25 PM, Marco Poletti wrote:
>>>>
>>>> @@ -112,6 +112,8 @@ function keyword_option(line) {
>>>> else if (args ~ /c$/)
>>>> format="c-format"
>>>>
>>>> + if (name ~ /_n$/) n = n "," (n + 1)
>>>> +
>>>> if (n == 1) { keyword = "--keyword=" name }
>>>> else { keyword = "--keyword=" name ":" n }
>>>> if (format) {
>>>>
>>>
>> Marco, xgettext can't accept the --flag argument that have more than one
>> argnums. It will have the argnums like 2,3 if the above code added.
>>
>> How about to only use the conditional expression like
>>
>> error (TREE_VEC_LENGTH (parms) > 1
>> ? G_("redeclared with %d template parameters")
>> : G_("redeclared with %d template parameter"),
>> TREE_VEC_LENGTH (parms));
>>
>> it changed less to fix this problem.
>
> this is close to what I originally had in mind
>
>>
>> Pearly
>>
>
So, can this be committed?
Marco
next prev parent reply other threads:[~2010-02-26 7:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 15:23 Marco Poletti
2010-02-17 15:25 ` Marco Poletti
2010-02-17 17:06 ` Gabriel Dos Reis
2010-02-17 18:02 ` Marco Poletti
2010-02-17 18:29 ` Paolo Bonzini
2010-02-17 20:07 ` Marco Poletti
2010-02-17 21:26 ` Joseph S. Myers
2010-02-17 21:32 ` Marco Poletti
2010-02-17 23:23 ` Paolo Bonzini
2010-02-18 14:33 ` Marco Poletti
2010-02-18 14:40 ` Jakub Jelinek
2010-02-18 14:49 ` Marco Poletti
2010-02-22 9:38 ` Marco Poletti
2010-02-24 6:47 ` Shujing Zhao
2010-02-24 6:57 ` Paolo Bonzini
2010-02-24 8:55 ` Shujing Zhao
2010-02-24 10:22 ` Paolo Bonzini
2010-02-26 7:30 ` Gabriel Dos Reis
2010-02-26 7:31 ` Marco Poletti [this message]
2010-02-26 9:32 ` Gabriel Dos Reis
2010-02-26 9:43 ` Paolo Bonzini
2010-02-26 9:56 ` Gabriel Dos Reis
2010-02-26 10:03 ` Jakub Jelinek
2010-02-26 10:04 ` Gabriel Dos Reis
2010-02-26 10:09 ` Shujing Zhao
2010-02-26 10:42 ` Paolo Bonzini
2010-02-26 10:43 ` Jakub Jelinek
2010-03-01 10:00 ` Shujing Zhao
2010-03-01 10:16 ` Shujing Zhao
2010-03-01 15:12 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae2276fe1002252313w3d435534ge5f22627b898225a@mail.gmail.com \
--to=poletti.marco@gmail.com \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=paolo.carlini@oracle.com \
--cc=pearly.zhao@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).