From: Jeff Law <jeffreyalaw@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [committed] m32r: Fix up m32r_setup_incoming_varargs [PR114175]
Date: Wed, 20 Mar 2024 12:14:26 -0600 [thread overview]
Message-ID: <ae26ec0e-eea5-4c25-9e1e-3a6d0f2b9894@gmail.com> (raw)
In-Reply-To: <Zfsc8RxRszNnFOWq@tucnak>
On 3/20/24 11:29 AM, Jakub Jelinek wrote:
> On Wed, Mar 20, 2024 at 10:58:05AM -0600, Jeff Law wrote:
>> On 3/20/24 10:06 AM, Jakub Jelinek wrote:
>>> Like for x86-64, alpha or rs6000, m32r seems to be affected too.
>>>
>>> Just visually checked differences in c23-stdarg-9.c assembly in a cross
>>> without/with the patch, committed to trunk.
>>>
>> That fixed c23-stdarg-{6,8,9} execution tests.
>
> Thanks for these checks. All I've done with the remaining targets
> today (csky-linux epiphany-elf fr30-elf frv-linux ft32-elf m32r-elf mcore-elf
> mmix-knuth-mmixware nds32-linux nios2-linux sh-linux visium-elf) was
> build crosses (without binutils, so stopped shortly after building cc1),
> make a copy of cc1, try expected tweaks in config/*/*.cc around the
> TYPE_NO_NAMED_ARGS_STDARG_P uses unless it was clearly unnecessary,
> make cc1 again and compare if the c23-stdarg-9.c assembly is any different,
> if yes, try to eyeball it if the changes are desired, if the assembly is
> unmodified, throw away the changes.
>
> With the changes by others (loongarch, mips, riscv) I hope we are good on
> the c23-stdarg-*.c tests on all arches.
Forgot to note, arc-elf started passing c23-stdarg-9.c yesterday.
Started an off-cycle run of the alpha, so figure this time tomorrow
we'll have confirmation it's working.
Jeff
prev parent reply other threads:[~2024-03-20 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 16:06 Jakub Jelinek
2024-03-20 16:58 ` Jeff Law
2024-03-20 17:29 ` Jakub Jelinek
2024-03-20 18:14 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae26ec0e-eea5-4c25-9e1e-3a6d0f2b9894@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).