From: Bruce Korb <bkorb@gnu.org>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] Fix fixincludes for canadian cross builds
Date: Sat, 18 Feb 2017 01:07:00 -0000 [thread overview]
Message-ID: <ae284938-736a-ae50-1380-86a5e03250fa@gnu.org> (raw)
In-Reply-To: <AM4PR0701MB216279A16CA1B1D69DCFE1D7E4400@AM4PR0701MB2162.eurprd07.prod.outlook.com>
On 02/06/17 10:44, Bernd Edlinger wrote:
> I tested this change with different arm-linux-gnueabihf cross
> compilers, and verified that mkheaders still works on the host system.
>
> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
> Is it OK for trunk?
As long as you certify that this is correct for all systems we care about:
+BUILD_SYSTEM_HEADER_DIR = `
+ echo $(CROSS_SYSTEM_HEADER_DIR) | \
+ sed -e :a -e 's,[^/]*/\.\.\/,,' -e ta`
that is pretty obtuse sed-speak to me. I suggest a comment
explaining what sed is supposed to be doing. What should
"$(CROSS_SYSTEM_HEADER_DIR)" look like?
next prev parent reply other threads:[~2017-02-17 23:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 18:44 Bernd Edlinger
2017-02-18 1:07 ` Bruce Korb [this message]
2017-02-18 11:39 ` Bernd Edlinger
2017-02-20 18:18 ` Bruce Korb
2017-04-12 15:59 ` Yvan Roux
2017-04-12 16:22 ` Bruce Korb
2017-04-14 4:18 ` Bernd Edlinger
2017-04-14 8:24 ` Yvan Roux
2017-04-14 10:37 ` Bernd Edlinger
2017-04-14 11:20 ` Yvan Roux
2017-04-18 18:29 ` Bernd Edlinger
2017-04-19 7:56 ` Yvan Roux
2017-04-20 20:29 ` [PATCH] Fix fixincludes for canadian cross builds - next try Bernd Edlinger
2017-04-20 20:35 ` Matthew Fortune
2017-04-21 10:41 ` Yvan Roux
2017-04-28 19:13 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae284938-736a-ae50-1380-86a5e03250fa@gnu.org \
--to=bkorb@gnu.org \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).