From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"H.J. Lu" <hjl.tools@gmail.com>, Jakub Jelinek <jakub@redhat.com>,
Richard Biener <richard.guenther@gmail.com>,
AlanM <amodra@gmail.com>, Peter Bergner <bergner@linux.ibm.com>,
Richard Sandiford <richard.sandiford@arm.com>,
David Edelsohn <dje.gcc@gmail.com>,
jlaw@ventanamicro.com
Subject: Re: [PATCH] Adjust the symbol for SECTION_LINK_ORDER linked_to section [PR99889]
Date: Fri, 30 Sep 2022 20:47:53 +0800 [thread overview]
Message-ID: <ae2ba411-d493-bedb-be70-d3e15bc13503@linux.ibm.com> (raw)
In-Reply-To: <20220929203150.GG25951@gate.crashing.org>
Hi Segher,
on 2022/9/30 04:31, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Aug 24, 2022 at 04:17:07PM +0800, Kewen.Lin wrote:
>> --- a/gcc/config/rs6000/rs6000.cc
>> +++ b/gcc/config/rs6000/rs6000.cc
>> @@ -14771,18 +14771,9 @@ rs6000_print_patchable_function_entry (FILE *file,
>> unsigned HOST_WIDE_INT patch_area_size,
>> bool record_p)
>> {
>> - unsigned int flags = SECTION_WRITE | SECTION_RELRO;
>> - /* When .opd section is emitted, the function symbol
>> - default_print_patchable_function_entry_1 is emitted into the .opd section
>> - while the patchable area is emitted into the function section.
>> - Don't use SECTION_LINK_ORDER in that case. */
>> - if (!(TARGET_64BIT && DEFAULT_ABI != ABI_ELFv2)
>> - && HAVE_GAS_SECTION_LINK_ORDER)
>> - flags |= SECTION_LINK_ORDER;
>> - default_print_patchable_function_entry_1 (file, patch_area_size, record_p,
>> - flags);
>> + default_print_patchable_function_entry (file, patch_area_size, record_p);
>> }
>
> Please don't define TARGET_ASM_PRINT_PATCHABLE_FUNCTION_ENTRY at all,
> instead, and remove this whole function?
This hook is still needed for "ELFv2 support rework" which
was just committed in r13-2984. There is also a note
explaining this in the original mail:
"btw, rs6000_print_patchable_function_entry can be dropped
but there is another rs6000 patch which needs this rs6000
specific hook rs6000_print_patchable_function_entry, not
sure which one gets landed first, so just leave it here."
>
> The rs6000 changes are okay like that, thanks!
Thanks!
BR,
Kewen
next prev parent reply other threads:[~2022-09-30 12:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 8:17 Kewen.Lin
2022-09-28 5:41 ` PING^1 " Kewen.Lin
2022-11-10 8:15 ` PING^2 " Kewen.Lin
2022-11-21 14:20 ` Richard Sandiford
2022-11-22 2:58 ` Kewen.Lin
2022-11-22 16:08 ` Richard Sandiford
2022-11-25 3:26 ` Kewen.Lin
2023-07-19 6:33 ` Fangrui Song
2023-07-19 8:49 ` Kewen.Lin
2022-09-29 20:31 ` Segher Boessenkool
2022-09-30 12:47 ` Kewen.Lin [this message]
2022-09-30 17:47 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae2ba411-d493-bedb-be70-d3e15bc13503@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=amodra@gmail.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=jlaw@ventanamicro.com \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).