From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from butterfly.birch.relay.mailchannels.net (butterfly.birch.relay.mailchannels.net [23.83.209.27]) by sourceware.org (Postfix) with ESMTPS id 2CC193858406 for ; Mon, 22 Nov 2021 12:31:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CC193858406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D50F8621A56; Mon, 22 Nov 2021 12:31:15 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D3370621AA8; Mon, 22 Nov 2021 12:31:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.65.138 (trex/6.4.3); Mon, 22 Nov 2021 12:31:15 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Stop-Coil: 1a3be30d6d1c9376_1637584275329_3133321796 X-MC-Loop-Signature: 1637584275329:491487266 X-MC-Ingress-Time: 1637584275329 Received: from [192.168.1.174] (unknown [1.186.224.140]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4HyRTF2fNTz1X1; Mon, 22 Nov 2021 04:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1637584274; bh=i0gCf4ZFVoYHLcGLYaKqQlP2mtU=; h=Date:Subject:From:To:Cc:Content-Type:Content-Transfer-Encoding; b=dj/bdF9aO5OeGhgB2rBePDmBqGFKznnaK8/eoUw+xK95QhraHRzzk0RzEg+l7uXHN 6vVEYhb5aReaWjAakEXfTQ+TCXLdBitK1dVl6O0TDBuMYLQ/iAexxlH3ahVzrFrLS9 NuvikWk19mnph9qZCyEDSlYdKi5gW9frNRHZL+yA= Message-ID: Date: Mon, 22 Nov 2021 18:01:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 03/10] tree-object-size: Use tree instead of HOST_WIDE_INT Content-Language: en-US From: Siddhesh Poyarekar To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211109190137.1107736-4-siddhesh@gotplt.org> <20211119170639.GT2646553@tucnak> <7915f97c-54ca-1d23-506a-bc916620c12a@gotplt.org> <20211122103150.GL2646553@tucnak> <1468e98c-7834-b6eb-593d-53bfa1430f83@gotplt.org> In-Reply-To: <1468e98c-7834-b6eb-593d-53bfa1430f83@gotplt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3029.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 12:31:20 -0000 On 11/22/21 17:30, Siddhesh Poyarekar wrote: > So I've got patch 10/10, which handles dynamic (and consequently > negative) offsets.  It basically computes a "whole size", which then > gives the extent to which a negative offset is valid, making the > estimates a bit more precise.  I didn't do it for static object sizes > because I didn't have time then, but I could add a patch 11/10 if the > idea sounds OK to you. ... or alternatively, I could bring the whole size idea into this tree conversion patch so that it handles all kinds of offsets. That might even eliminate patch 10/10. What would you prefer? Siddhesh