public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: C++ 20 modules
Date: Tue, 22 Dec 2020 23:48:26 +0100 (CET)	[thread overview]
Message-ID: <ae5dc4ce-a1cb-febe-8b7b-ca1ec74bab25@pfeifer.com> (raw)
In-Reply-To: <6f637593-02f8-2bda-af10-365288269917@acm.org>

On Mon, 21 Dec 2020, Nathan Sidwell wrote:
> Yes, this is good.  I already managed to commit some of this with 
> the 98412 patch.

I wasn't sure, but seeing that you had not applied this, I figured
this was approval and pushed the remaining portion this afternoon,
per the below.

Gerald

PS: I am really starting to like our use of git.


commit 7e63d383b89cd75b7775883d71ed09724b9ee73f
Author: Gerald Pfeifer <gerald@pfeifer.com>
Date:   Tue Dec 22 13:37:56 2020 +0100

    c++: Fix build with clang
    
    After the addition of libcody building with clang 10.0.1 would fail
    as follows:
    
      In file included from .../libcody/cody.hh:24:
      In file included from /usr/include/c++/v1/memory:653:
      /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'
      in namespace 'std::__1'; did you mean simply 'fancy_abort'?
        _VSTD::abort();
        ^~~~~~~
    
    mapper-client.cc and mapper-resolver.cc have addressed this already
    by getting <string> and <vector> included; do the same for module.cc.
    
    gcc/cp:
    2020-12-22  Gerald Pfeifer  <gerald@pfeifer.com>
    
            * module.cc (INCLUDE_STRING): Define.
            (INCLUDE_VECTOR): Ditto.

diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc
index 7e38293545f..ed3dbe244a3 100644
--- a/gcc/cp/module.cc
+++ b/gcc/cp/module.cc
@@ -207,6 +207,8 @@ Classes used:
 
 #define _DEFAULT_SOURCE 1 /* To get TZ field of struct tm, if available.  */
 #include "config.h"
+#define INCLUDE_STRING
+#define INCLUDE_VECTOR
 #include "system.h"
 #include "coretypes.h"
 #include "cp-tree.h"

      reply	other threads:[~2020-12-22 22:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 15:49 Nathan Sidwell
2020-12-15 22:33 ` Nathan Sidwell
2020-12-15 22:42   ` Rainer Orth
2020-12-16 21:52   ` Nathan Sidwell
2020-12-17 21:37     ` Nathan Sidwell
2020-12-20 23:57       ` Gerald Pfeifer
2020-12-21 13:55         ` Nathan Sidwell
2020-12-21 17:38           ` Gerald Pfeifer
2020-12-21 17:45             ` Nathan Sidwell
2020-12-22 22:48               ` Gerald Pfeifer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae5dc4ce-a1cb-febe-8b7b-ca1ec74bab25@pfeifer.com \
    --to=gerald@pfeifer.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).