From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) by sourceware.org (Postfix) with ESMTPS id C0B86383302D for ; Tue, 22 Dec 2020 22:48:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C0B86383302D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pfeifer.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gerald@pfeifer.com Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 5129F33E5A; Tue, 22 Dec 2020 17:48:35 -0500 (EST) Received: from [192.168.1.5] (77.118.226.34.wireless.dyn.drei.com [77.118.226.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id CAE3533E55; Tue, 22 Dec 2020 17:48:34 -0500 (EST) Date: Tue, 22 Dec 2020 23:48:26 +0100 (CET) From: Gerald Pfeifer To: Nathan Sidwell cc: gcc-patches@gcc.gnu.org Subject: Re: C++ 20 modules In-Reply-To: <6f637593-02f8-2bda-af10-365288269917@acm.org> Message-ID: References: <71a3e6c0-3138-cc6d-e2b7-954d906a2a4a@acm.org> <00534e11-85e3-ef81-b330-9d9ecf427629@acm.org> <41e5175-afe7-55cf-1bf-ca412bd6dbe2@pfeifer.com> <974febbd-dfe9-507e-e2e4-22e885fd3ec9@acm.org> <3521e113-eada-2b68-d21e-b6fb8ed320b4@pfeifer.com> <6f637593-02f8-2bda-af10-365288269917@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 22:48:36 -0000 On Mon, 21 Dec 2020, Nathan Sidwell wrote: > Yes, this is good. I already managed to commit some of this with > the 98412 patch. I wasn't sure, but seeing that you had not applied this, I figured this was approval and pushed the remaining portion this afternoon, per the below. Gerald PS: I am really starting to like our use of git. commit 7e63d383b89cd75b7775883d71ed09724b9ee73f Author: Gerald Pfeifer Date: Tue Dec 22 13:37:56 2020 +0100 c++: Fix build with clang After the addition of libcody building with clang 10.0.1 would fail as follows: In file included from .../libcody/cody.hh:24: In file included from /usr/include/c++/v1/memory:653: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort' in namespace 'std::__1'; did you mean simply 'fancy_abort'? _VSTD::abort(); ^~~~~~~ mapper-client.cc and mapper-resolver.cc have addressed this already by getting and included; do the same for module.cc. gcc/cp: 2020-12-22 Gerald Pfeifer * module.cc (INCLUDE_STRING): Define. (INCLUDE_VECTOR): Ditto. diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc index 7e38293545f..ed3dbe244a3 100644 --- a/gcc/cp/module.cc +++ b/gcc/cp/module.cc @@ -207,6 +207,8 @@ Classes used: #define _DEFAULT_SOURCE 1 /* To get TZ field of struct tm, if available. */ #include "config.h" +#define INCLUDE_STRING +#define INCLUDE_VECTOR #include "system.h" #include "coretypes.h" #include "cp-tree.h"