From: Jeff Law <jeffreyalaw@gmail.com>
To: Di Zhao OS <dizhao@os.amperecomputing.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] [tree-optimization/110279] fix testcase pr110279-1.c
Date: Wed, 22 May 2024 09:13:37 -0600 [thread overview]
Message-ID: <ae7b2c3c-a935-4372-93d7-6ede95d766ca@gmail.com> (raw)
In-Reply-To: <SJ2PR01MB8193FE48847E289D12C76171E8EB2@SJ2PR01MB8193.prod.exchangelabs.com>
On 5/22/24 5:46 AM, Di Zhao OS wrote:
> The test case is for targets that support FMA. Previously
> the "target" selector is missed in dg-final command.
>
> Tested on x86_64-pc-linux-gnu.
>
> Thanks
> Di Zhao
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/pr110279-1.c: add target selector.
Rather than list targets explicitly in the test, wouldn't it be better
to have a common routine that could be used in other cases where we have
a test that requires FMA?
So something similar to check_effective_target_scalar_all_fma?
JEff
next prev parent reply other threads:[~2024-05-22 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 11:46 Di Zhao OS
2024-05-22 15:13 ` Jeff Law [this message]
2024-05-23 9:55 ` Di Zhao OS
2024-06-18 1:51 ` [PING][PATCH] " Di Zhao OS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae7b2c3c-a935-4372-93d7-6ede95d766ca@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=dizhao@os.amperecomputing.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).