From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 5922D3858D38 for ; Wed, 22 May 2024 15:13:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5922D3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5922D3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716390822; cv=none; b=fYFh7Nac9onBHahhYBn8dXbwufEix/HZx3L2rQCTIbZ4kdhfzKibV3AZTkl/3uEAdjzonXy8SsJdLoi6NBRwb6qERoRAX8Tcon7jsmpOA+OZ2+fScTyJseT8bnpPfqUitv5m6mhP09g73R20cPzQKCxG0uCcHDlW1wl3yo6LUGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716390822; c=relaxed/simple; bh=irUi0KzJPZAYC414vC/2EbvroO0ufZUkk5YfAwFv8YE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tXNsDRIiXuOcmqlblUre8v43ylF0SJoAo1fQWiTeYE8feTeH7S8YqbUyjVK4MlrACLLHQQEy3I81Z/g+Esrk9nuTbguujGR/WDk6uN6Gjz4zQMN19vA8k6RvAkvMY36SsNLNfxsjiCXWAFYESmy1oBFJOVpqwpmnL+WBNXbloPc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6f44b390d5fso1387701b3a.3 for ; Wed, 22 May 2024 08:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716390819; x=1716995619; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CVXyqmJxlq1/yf1P7w4wuFKqyTaXtM4UuYuMJNX9JSw=; b=Gy8uak/rl0puRzQzkrMy4RjRFnTuutHbjWJ+IJqJdMGhtko8YeqpuusiQaGxyXScwu YMUhwQZ9p8LohsHK7K/63eBZ5mae2hu8z+HkneQonnZMkeHLjunX8ph5EpKwIzjwrTdR KL/L4Uhfmfe1NNh1zwsnuk7V17XG5T8VG4MNUx2ky3ri1y5eiz1/HQx1aivYenGPgelt iDp9iKFcXs1cjIOi5G0VZmrawW/CDSt0am7TNE6w0ReEtCNzTsbvc6Tl8WQDpTwGakvA F3HBWulBD8+wjaHp7fdpXKqaorignwgrrBSL8mfHm0kZtbc7XC2sakmGd+n8pfC2TxEH i2hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716390819; x=1716995619; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CVXyqmJxlq1/yf1P7w4wuFKqyTaXtM4UuYuMJNX9JSw=; b=qfaA/eIxYdp12tFjA7zy7yxCqfzQLjglIen4JRjhkPIkWXAWt2GbsVnezxEn1gGvo+ J6CwIRI4K6lXSseeZHN2+4YBdG0Kz4/HkfWYEBn09+FuELnW8pBfvHuwWNjLS/7+BRLD Ay5NbwmHr+2NH3HnaU0/M1o3qAWHedP/n6W05rScbd9CSutlwyr0jZkdnLamUOYueRm5 F18K4Ex3Z+jcgve+qemdnaSidhcJyfffOnDdsNWPzTJxJtqZEnaYhGBm3WCdBuo7H2xz tGq07sbDw8vg1FM0439U3Px5/nKvg7Ew/0YdcvobwCLbCvGnGZFAwdgEcPdZE0X18rVn mIxg== X-Forwarded-Encrypted: i=1; AJvYcCXteBpWFe2XFIfj59OzHWGUal+xzA/Qma31AYaBewuNbFr9SFx+8G58odO0k2HBAroWDwnj9c503cw0sS0YOyW72qQz0RExYg== X-Gm-Message-State: AOJu0YzHlq4/yVoIOu7WTXse/8u2CunsGrbUxe/Tfp3Uaa9SKtRuTyjQ WJtS6xl383KqgM2OfVlUZkdU39FqbUVQROjKybiKkn+yOa19GW2KsY6Lgcyz X-Google-Smtp-Source: AGHT+IFvgqye75Lj/Fl/nc2PCVqsJUZUBVHcl1ZJUuy0SPSCsfe4wKRoO6h9IxwhSuCNrWrwVMqt2g== X-Received: by 2002:a17:902:e848:b0:1f3:361a:661b with SMTP id d9443c01a7336-1f3361a66b1mr463395ad.46.1716390818995; Wed, 22 May 2024 08:13:38 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f303aba813sm52185265ad.146.2024.05.22.08.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 08:13:38 -0700 (PDT) Message-ID: Date: Wed, 22 May 2024 09:13:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] [tree-optimization/110279] fix testcase pr110279-1.c Content-Language: en-US To: Di Zhao OS , "gcc-patches@gcc.gnu.org" References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/22/24 5:46 AM, Di Zhao OS wrote: > The test case is for targets that support FMA. Previously > the "target" selector is missed in dg-final command. > > Tested on x86_64-pc-linux-gnu. > > Thanks > Di Zhao > > gcc/testsuite/ChangeLog: > > * gcc.dg/pr110279-1.c: add target selector. Rather than list targets explicitly in the test, wouldn't it be better to have a common routine that could be used in other cases where we have a test that requires FMA? So something similar to check_effective_target_scalar_all_fma? JEff