public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Patrick O'Neill <patrick@rivosinc.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: thomas <thomas@codesourcery.com>, fweimer <fweimer@redhat.com>
Subject: Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors
Date: Fri, 1 Dec 2023 17:10:21 -0800	[thread overview]
Message-ID: <ae85e4b7-99ac-45a3-ab54-ae0cd7ece852@rivosinc.com> (raw)
In-Reply-To: <B96947B90C2CA5FA+202312020833055146719@rivai.ai>

[-- Attachment #1: Type: text/plain, Size: 24331 bytes --]

Hi Juzhe,

I can confirm the failure on Newlib.
I'm not seeing any issues on glibc 2.37.
I haven't tried to build musl.

Since this patch promotes warnings to errors breakages were probably 
expected.
The fix may require changes to newlib to remove the errors.
I've hacked together a series of patches on top of newlib 4.3.0 that 
resolves these issues (but I think they'd need more work to be 
upstream-able):
https://github.com/patrick-rivos/riscv-gnu-toolchain/tree/35d8e8c486bd2f6e3e2e673db8d2b979309a6de4/fixups/newlib

@Thomas @Florian am I right in assuming that breakages were expected/the 
fix should come from fixing the warnings?

Thanks,
Patrick

On 12/1/23 16:33, 钟居哲 wrote:
> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:
>
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     8 |   return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
>       |                                        ^~~~
>       |                                        |
>       |                                        const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_utime.c:5:39: 
> warning: 'struct utimbuf' declared inside parameter list will not be 
> visible outside of this definition or declaration
>     5 | _utime(const char *path, const struct utimbuf *times)
>       |                                       ^~~~~~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c: 
> In function '_faccessat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c:7:50: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     7 |   return syscall_errno (SYS_faccessat, 4, dirfd, file, mode, 
> flags, 0, 0);
>       | ^~~~
>       |                                                  |
>       | const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_faccessat.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> make[5]: *** [Makefile:3315: riscv/riscv_libgloss_a-sys_access.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c: 
> In function '_open':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c:8:38: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     8 |   return syscall_errno (SYS_open, 3, name, flags, mode, 0, 0, 0);
>       |                                      ^~~~
>       |                                      |
>       |                                      const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_open.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c: 
> In function '_openat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c:7:47: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     7 |   return syscall_errno (SYS_openat, 4, dirfd, name, flags, 
> mode, 0, 0);
>       |                                               ^~~~
>       |                                               |
>       |                                               const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_openat.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> make[5]: *** [Makefile:3427: riscv/riscv_libgloss_a-sys_faccessat.o] 
> Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c: 
> In function '_link':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:7:38: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     7 |   return syscall_errno (SYS_link, 2, old_name, new_name, 0, 0, 
> 0, 0);
>       |                                      ^~~~~~~~
>       |                                      |
>       |                                      const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_link.c:7:48: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     7 |   return syscall_errno (SYS_link, 2, old_name, new_name, 0, 0, 
> 0, 0);
>       | ^~~~~~~~
>       |                                                |
>       | const char *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c: 
> In function '_fstat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c:12:47: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    12 |   int rv = syscall_errno (SYS_fstat, 2, file, &kst, 0, 0, 0, 0);
>       |                                               ^~~~
>       |                                               |
>       |  struct kernel_stat *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c: 
> In function '_fstatat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:11:50: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    11 |   int rv = syscall_errno (SYS_fstatat, 4, dirfd, file, &kst, 
> flags, 0, 0);
>       | ^~~~
>       |                                                  |
>       | const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_fstatat.c:11:56: 
> error: passing argument 5 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    11 |   int rv = syscall_errno (SYS_fstatat, 4, dirfd, file, &kst, 
> flags, 0, 0);
>       |     ^~~~
>       |     |
>       |     struct kernel_stat *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c: 
> In function '_unlink':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:58: 
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |  ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c:8:40: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     8 |   return syscall_errno (SYS_unlink, 1, name, 0, 0, 0, 0, 0);
>       |                                        ^~~~
>       |                                        |
>       |                                        const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_unlink.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c: 
> In function '_access':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     8 |   return syscall_errno (SYS_access, 2, file, mode, 0, 0, 0, 0);
>       |                                        ^~~~
>       |                                        |
>       |                                        const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:2:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c: 
> In function '_read':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c:8:44: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     8 |   return syscall_errno (SYS_read, 3, file, ptr, len, 0, 0, 0);
>       |                                            ^~~
>       |                                            |
>       |                                            void *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_read.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'void *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> make[5]: *** [Makefile:3609: riscv/riscv_libgloss_a-sys_open.o] Error 1
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c: 
> In function '_lstat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:10:41: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    10 |   int rv = syscall_errno (SYS_lstat, 2, file, &kst, 0, 0, 0, 0);
>       |                                         ^~~~
>       |                                         |
>       |                                         const char *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_lstat.c:10:47: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    10 |   int rv = syscall_errno (SYS_lstat, 2, file, &kst, 0, 0, 0, 0);
>       |                                               ^~~~
>       |                                               |
>       |  struct kernel_stat *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c: 
> In function '_write':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c:9:45: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>     9 |   return syscall_errno (SYS_write, 3, file, ptr, len, 0, 0, 0);
>       |                                             ^~~
>       |                                             |
>       |                                             const void *
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_write.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'const void *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c: 
> In function '_stat':
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:11:40: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    11 |   int rv = syscall_errno (SYS_stat, 2, file, &kst, 0, 0, 0, 0);
>       |                                        ^~~~
>       |                                        |
>       |                                        const char *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c: 
> In function '_gettimeofday':
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:3:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'const char *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_stat.c:11:46: 
> error: passing argument 4 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    11 |   int rv = syscall_errno (SYS_stat, 2, file, &kst, 0, 0, 0, 0);
>       |                                              ^~~~
>       |                                              |
>       |                                              struct kernel_stat *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c:29:46: 
> error: passing argument 3 of 'syscall_errno' makes integer from 
> pointer without a cast [-Wint-conversion]
>    29 |   return syscall_errno (SYS_gettimeofday, 1, tp, 0, 0, 0, 0, 0);
>       |                                              ^~
>       |                                              |
>       |                                              struct timeval *
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:48: 
> note: expected 'long int' but argument is of type 'struct kernel_stat *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                           ~~~~~^~~
> In file included from 
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_gettimeofday.c:4:
> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/internal_syscall.h:66:38: 
> note: expected 'long int' but argument is of type 'struct timeval *'
>    66 | syscall_errno(long n, int argc, long _a0, long _a1, long _a2, 
> long _a3, long _a4, long _a5)
>       |                                 ~~~~~^~~
> make[5]: *** [Makefile:3623: riscv/riscv_libgloss_a-sys_openat.o] Error 1
> make[5]: *** [Makefile:3567: riscv/riscv_libgloss_a-sys_link.o] Error 1
> make[5]: *** [Makefile:3455: riscv/riscv_libgloss_a-sys_fstat.o] Error 1
> make[5]: *** [Makefile:3469: riscv/riscv_libgloss_a-sys_fstatat.o] Error 1
> make[5]: *** [Makefile:3707: riscv/riscv_libgloss_a-sys_unlink.o] Error 1
> make[5]: *** [Makefile:4127: riscv/riscv_libsim_a-sys_access.o] Error 1
> make[5]: *** [Makefile:3637: riscv/riscv_libgloss_a-sys_read.o] Error 1
> make[5]: *** [Makefile:3595: riscv/riscv_libgloss_a-sys_lstat.o] Error 1
> make[5]: *** [Makefile:3749: riscv/riscv_libgloss_a-sys_write.o] Error 1
> make[5]: *** [Makefile:3665: riscv/riscv_libgloss_a-sys_stat.o] Error 1
> make[5]: *** [Makefile:3525: 
> riscv/riscv_libgloss_a-sys_gettimeofday.o] Error 1
>
>
> ------------------------------------------------------------------------
> juzhe.zhong@rivai.ai

  reply	other threads:[~2023-12-02  1:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02  0:33 钟居哲
2023-12-02  1:10 ` Patrick O'Neill [this message]
2023-12-02  1:53   ` 钟居哲
2023-12-02  3:25     ` Patrick O'Neill
2023-12-02  1:13 ` Sam James
2023-12-02  3:40   ` Jeff Law
2023-12-02  5:47     ` Sam James
2023-12-02 15:19       ` Jeff Law
2023-12-04  7:45         ` Kito Cheng
2023-12-05  0:25           ` Kito Cheng
  -- strict thread matches above, loose matches on Subject: below --
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
2023-11-13 19:24   ` Jeff Law
2023-12-01 11:29   ` Thomas Schwinge
2023-12-01 11:36     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae85e4b7-99ac-45a3-ab54-ae0cd7ece852@rivosinc.com \
    --to=patrick@rivosinc.com \
    --cc=fweimer@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).