From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48763 invoked by alias); 6 Oct 2016 09:47:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48739 invoked by uid 89); 6 Oct 2016 09:47:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nm, Hx-languages-length:762 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 09:47:08 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62D62335F6A; Thu, 6 Oct 2016 09:47:07 +0000 (UTC) Received: from localhost.localdomain (vpn1-6-105.ams2.redhat.com [10.36.6.105]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u969l50k032268; Thu, 6 Oct 2016 05:47:05 -0400 Subject: Re: [PATCH 3/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] To: Denys Vlasenko , gcc-patches@gcc.gnu.org References: <20160930175434.13194-1-dvlasenk@redhat.com> <20160930175434.13194-4-dvlasenk@redhat.com> Cc: Andrew Pinski , Uros Bizjak From: Bernd Schmidt Message-ID: Date: Thu, 06 Oct 2016 09:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160930175434.13194-4-dvlasenk@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00359.txt.bz2 On 09/30/2016 07:54 PM, Denys Vlasenko wrote: > +struct target_flag_state { > + /* Each falign-foo can generate up to two levels of alignment: > + -falign-foo=N,M[,N2,M2] */ > + struct align_flags x_align_loops[2]; > + struct align_flags x_align_jumps[2]; > + struct align_flags x_align_labels[2]; > + struct align_flags x_align_functions[2]; > +#define align_loops (this_target_flag_state->x_align_loops) > +#define align_jumps (this_target_flag_state->x_align_jumps) > +#define align_labels (this_target_flag_state->x_align_labels) In addition to the points already raised, this also breaks ports which access variables like align_jumps and expect them to be integers. rs6000 is one such port. Bernd