From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4247 invoked by alias); 6 Sep 2019 08:04:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4225 invoked by uid 89); 6 Sep 2019 08:04:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:nycvar., HContent-Transfer-Encoding:8bit X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2019 08:04:15 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2FE91ADBF; Fri, 6 Sep 2019 08:04:13 +0000 (UTC) Subject: Re: [PATCH][middle-end/88784] Middle end is missing some optimizations about unsigned To: Richard Biener Cc: Li Jia He , Andrew Pinski , Jeff Law , GCC Patches , Segher Boessenkool , wschmidt@linux.ibm.com, Martin Liska References: <1561615913-22109-1-git-send-email-helijia@linux.ibm.com> <6fb28248-5134-cec5-5045-45253e4d2eb0@redhat.com> <6d333ccf-9905-e929-c2dc-fc611ff929f1@linux.ibm.com> <845bc280-7bd6-509b-3830-4ebde50f1b20@linux.ibm.com> <47201224-c3bf-a849-30cb-f115a050f9de@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Fri, 06 Sep 2019 08:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00337.txt.bz2 On 9/6/19 10:01 AM, Richard Biener wrote: > On Thu, 5 Sep 2019, Martin Liška wrote: > >> On 9/5/19 3:01 PM, Richard Biener wrote: >>> Not sure if you or Martin wants to improve it according to my >>> comments. >> >> Yes please. I'm working on that based on the review you provided. > > Oh, and it just occured to me since we're doing single_use checks > on SSA names in match.pd that you need to initialize the > SSA_NAME_IMM_USE_NODE () as well - see make_ssa_name_fn, probably > makes sense to split out a short helper for that. Yes, I already hit the ICE :) Martin > > Richard. >