From: David Malcolm <dmalcolm@redhat.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: Silence analyzer/pr51628-30.c for default_packed
Date: Mon, 09 May 2022 08:53:04 -0400 [thread overview]
Message-ID: <aeb8b598443230885b3d3a1c6ad57e424300cccf.camel@redhat.com> (raw)
In-Reply-To: <20220508073104.1698197-1-dimitar@dinux.eu>
On Sun, 2022-05-08 at 10:31 +0300, Dimitar Dimitrov wrote:
> On default_packed targets like PRU, a warning in the file included
> from
> analyzer/pr51628-30.c is reported as spurious one, even though it has
> been
> annotated there:
>
> Excess errors:
> gcc/gcc/testsuite/gcc.dg/analyzer/torture/../../../c-c++-
> common/pr51628-30.c:7:19: warning: 'packed' attribute ignored for
> field of type 'struct B' [-Wattributes]
>
> DejaGnu does not preprocess the C test case sources. Hence the "dg-
> *"
> statements in included files are ignored.
>
> Mark that gcc.dg/analyzer/torture/pr51628-30.c generates excess
> warnings
> for default_packed targets. This is safe because the original test
> case
> covered an ICE, not a diagnostic error.
Indeed; for reference, the ICE was part of PR analyzer/93388 (part of
ensuring that -fanalyzer doesn't ICE on less common tree codes).
>
> Ok for trunk?
Thanks; looks good to me. Sorry about the noise.
Dave
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/analyzer/torture/pr51628-30.c: Test can spill excess
> errors for default_packed targets.
>
> CC: David Malcolm <dmalcolm@redhat.com>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> gcc/testsuite/gcc.dg/analyzer/torture/pr51628-30.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/pr51628-30.c
> b/gcc/testsuite/gcc.dg/analyzer/torture/pr51628-30.c
> index 4513e0f890c..abc13413f2b 100644
> --- a/gcc/testsuite/gcc.dg/analyzer/torture/pr51628-30.c
> +++ b/gcc/testsuite/gcc.dg/analyzer/torture/pr51628-30.c
> @@ -1,3 +1,4 @@
> /* { dg-additional-options "-Wno-address-of-packed-member" } */
> +/* { dg-excess-errors "warnings about ignored 'packed' attribute" {
> target default_packed } } */
>
> #include "../../../c-c++-common/pr51628-30.c"
prev parent reply other threads:[~2022-05-09 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 7:31 Dimitar Dimitrov
2022-05-09 12:53 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb8b598443230885b3d3a1c6ad57e424300cccf.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=dimitar@dinux.eu \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).