From: Martin Sebor <msebor@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] add support for strnlen (PR 81384)
Date: Wed, 06 Jun 2018 15:14:00 -0000 [thread overview]
Message-ID: <af019350-d0b5-2269-e2e9-c2bb5e111298@gmail.com> (raw)
In-Reply-To: <20180605221957.GF14160@tucnak>
On 06/05/2018 04:19 PM, Jakub Jelinek wrote:
> On Tue, Jun 05, 2018 at 03:43:17PM -0600, Martin Sebor wrote:
>> --- a/gcc/builtins.def
>> +++ b/gcc/builtins.def
>> @@ -733,6 +733,7 @@ DEF_EXT_LIB_BUILTIN (BUILT_IN_STRNCASECMP, "strncasecmp", BT_FN_INT_CONST_STR
>> DEF_LIB_BUILTIN (BUILT_IN_STRNCAT, "strncat", BT_FN_STRING_STRING_CONST_STRING_SIZE, ATTR_RET1_NOTHROW_NONNULL_LEAF)
>> DEF_LIB_BUILTIN (BUILT_IN_STRNCMP, "strncmp", BT_FN_INT_CONST_STRING_CONST_STRING_SIZE, ATTR_PURE_NOTHROW_NONNULL_LEAF)
>> DEF_LIB_BUILTIN (BUILT_IN_STRNCPY, "strncpy", BT_FN_STRING_STRING_CONST_STRING_SIZE, ATTR_RET1_NOTHROW_NONNULL_LEAF)
>> +DEF_LIB_BUILTIN_CHKP (BUILT_IN_STRNLEN, "strnlen", BT_FN_SIZE_CONST_STRING_SIZE, ATTR_PURE_NOTHROW_NONNULL_LEAF)
>
> strnlen isn't a C89, C99 nor C11 function, so I think it should be
> DEF_EXT_LIB_BUILTIN like e.g. stpcpy, not DEF_LIB_BUILTIN.
Thanks. Let me change that.
> And not really sure it is worth adding the CHKP stuff when it will be just
> more work for Martin Liska to remove it again.
Sure, let me take that out.
Is there anything else?
Martin
next prev parent reply other threads:[~2018-06-06 15:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 21:43 Martin Sebor
2018-06-05 22:20 ` Jakub Jelinek
2018-06-06 15:14 ` Martin Sebor [this message]
2018-06-06 15:49 ` Jakub Jelinek
2018-06-06 0:39 ` Eric Gallager
2018-06-06 14:44 ` Martin Sebor
2018-06-12 15:10 ` PING " Martin Sebor
2018-06-12 21:11 ` Jeff Law
2018-06-18 16:35 ` Martin Sebor
2018-07-09 14:36 ` Aldy Hernandez
2018-07-09 19:51 ` Jeff Law
2018-07-09 20:51 ` Martin Sebor
2018-07-09 21:26 ` Martin Sebor
2018-07-10 7:13 ` Richard Biener
2018-07-10 14:10 ` Martin Sebor
2018-07-10 14:25 ` Richard Biener
2018-07-10 14:34 ` Jeff Law
2018-07-10 14:57 ` Martin Sebor
2018-06-19 19:33 David Edelsohn
2018-06-19 20:10 ` Martin Sebor
2018-06-19 20:25 ` Martin Sebor
2018-06-20 5:24 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af019350-d0b5-2269-e2e9-c2bb5e111298@gmail.com \
--to=msebor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).