From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id F291D3953838 for ; Sun, 19 Nov 2023 19:51:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F291D3953838 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F291D3953838 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700423480; cv=none; b=bQVZ/NUe3q2RIhLooN1V1SxPktCZYZ2fINiHDPQjh0h2rCaPWISNrdRaLLAgzgvS9w+s/qXQlcEzjDWT3gAjTMpn+45D27zwzKufoikAxhA/jzLPYyCXxzMpzwPmXJg9Uf71KZwQCEomAdcmVL9IESgxYdgXIMfyXzbHRJHFaV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700423480; c=relaxed/simple; bh=pWokxC11yI9gRDCXLJhvMOgu/JqxK7FxamQNi2I0lWI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GwG9OsGxewG6kyreAdNY7Klogj7QAQQk94zN1zo+oTfkiEpE34Ec0540m/EA9nTqdxZrp0/CT4ebHxd54tCqRpf/SP/mSNDix+rIelCH8OgcUnKayCG67OJF+iW1Scc7LNR/Hz31gq0s71D+j198G4qfr0sUhqQXFQHqnG7ry4M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6ce31c4a653so2174573a34.3 for ; Sun, 19 Nov 2023 11:51:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700423478; x=1701028278; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZK3b88xgiNbV4J0tt9+2iszjWN9yhvF2EcOjN/5wjyE=; b=IDEk54EIlj7CKcq445A987q2i7giSXub7wIX1NgqwHUqum3xvprKcRtHGLdMSCRyV2 uxf7CwqJMdUhB9xIfJj4V5T8g/5vFqiOUyop8+AcIFnfS36JMWP+6ShYz1fL94C9u84A l5a5Ktjzxu8chwIxmwp954Z1b+L6lZJimcJ6AvRoxpYi12x+pO7k6il6UVj7wEL6lxqF m+UCcGXvp/fHrfhuRzFkxYt7hBFINnKtze4GH0VsX4W5N/RHMxq1lscFINRddJKZrpJF mRi5ARL5fMuObgJEYnwkzxQI4IEGEA4iK1VpRGyuML7Y5l8whewPjiHW0/ULLvN8DsFt ZOPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700423478; x=1701028278; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZK3b88xgiNbV4J0tt9+2iszjWN9yhvF2EcOjN/5wjyE=; b=lR1Oo2MiP1fy1w1BKLU9L7H9O+bn2p1+KxMKCREshOR7TRcH42ZD2oKsIUDxuUgl9T 5dJSctY8ECG2Cc9CN9lx8W8zU5UcGnhZvgbozkUi/+HYSTTz9P28SKaXRVlfkMMxxusZ EqUJxKb4HUtFTPsdREA0ds6LNDqVaJ+F+afsd8DWFqET9ZJEJdeBkV8kl0kqBJ0aaT2m q9eQbQLw06dBmELTd6XjKjqQvCRT6ue4MSibnzkUbdAaCCr8ixZ2BoS1AAXYtZreyqOT J+nb5DhEKqwk9/SVmqmD7NQ4dPRnx7Cn8Qayb1JhsixCM+i0K9kAvNCH+UvrGtTYRR78 itpA== X-Gm-Message-State: AOJu0YyaVACP1pAqWfKYZTOknw7Q7I+4cEaxzAelE/3LCn75ZWf3lxs7 meQqMzRZuiZu3uA1z1zPb30= X-Google-Smtp-Source: AGHT+IGOlS4b3530ctrJG4jpCmjkdofCwBFlKXlhptNP87ZKE/WMCOqtwuS5/6BfZhzy2aYNFE/RrQ== X-Received: by 2002:a05:6830:18fa:b0:6d6:5382:159c with SMTP id d26-20020a05683018fa00b006d65382159cmr6726013otf.24.1700423478266; Sun, 19 Nov 2023 11:51:18 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id cz23-20020a0568306a1700b006b8b55297b5sm975567otb.42.2023.11.19.11.51.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 11:51:17 -0800 (PST) Message-ID: Date: Sun, 19 Nov 2023 12:51:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 40/44] RISC-V: Handle FP NE operator via inversion in cond-operation expansion Content-Language: en-US To: "Maciej W. Rozycki" , gcc-patches@gcc.gnu.org Cc: Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/23 22:43, Maciej W. Rozycki wrote: > We have no FNE.fmt machine instructions, but we can emulate them for the > purpose of conditional-move and conditional-add operations by using the > respective FEQ.fmt instruction and then swapping the data input operands > or complementing the mask for the conditional addend respectively, so > update our handlers accordingly. > > gcc/ > * config/riscv/riscv-protos.h (riscv_expand_float_scc): Add > `invert_ptr' parameter. > * config/riscv/riscv.cc (riscv_emit_float_compare): Add NE > inversion handling. > (riscv_expand_float_scc): Pass `invert_ptr' through to > `riscv_emit_float_compare'. > (riscv_expand_conditional_move): Pass `&invert' to > `riscv_expand_float_scc'. > * config/riscv/riscv.md (addcc): Likewise. This and the rest of the patches (41, 42, 43, 44) in this series are OK. I think between Kito and myself, we've reviewed the whole set, right? jeff