From: "Martin Liška" <mliska@suse.cz>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][V4] rs6000: Remove unnecessary option manipulation.
Date: Fri, 19 Nov 2021 13:31:21 +0100 [thread overview]
Message-ID: <af44220e-4502-a9e7-a63b-80d6d11558d8@suse.cz> (raw)
In-Reply-To: <8227e6a8-4c7e-aa4a-5e0a-37fe32f1c1e9@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
On 11/19/21 13:25, Martin Liška wrote:
> Fine. I've just done that.
All right, so I can't send an email from my local machine and git imap-send
does not work as it goes through Thunderbird.
So my last attempt is attaching the email so that you can add the .eml file.
Martin
[-- Attachment #2: patch.eml --]
[-- Type: message/rfc822, Size: 3226 bytes --]
From: Martin Liska <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Cc: segher@kernel.crashing.org, Martin Liska <mliska@suse.cz>
Subject: [PATCH][V4] rs6000: Remove unnecessary option manipulation.
Date: Fri, 12 Nov 2021 17:12:58 +0100
Message-ID: <20211112161258.9964-1-mliska@suse.cz>
Do not set flag_rename_registers, it's already enabled with EnabledBy(funroll-loops)
in the common.opt file. Use EnabledBy for unroll_only_small_loops which
is a canonical approach how can be make option dependencies.
gcc/ChangeLog:
* config/rs6000/rs6000.c (rs6000_override_options_after_change):
Do not set flag_rename_registers and unroll_only_small_loops.
* config/rs6000/rs6000.opt: Use EnabledBy for unroll_only_small_loops.
---
gcc/config/rs6000/rs6000.c | 7 +------
gcc/config/rs6000/rs6000.opt | 2 +-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index e4843eb0f1c..5550113a94c 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -3466,13 +3466,8 @@ rs6000_override_options_after_change (void)
/* Explicit -funroll-loops turns -munroll-only-small-loops off, and
turns -frename-registers on. */
if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops)
- || (OPTION_SET_P (flag_unroll_all_loops)
- && flag_unroll_all_loops))
+ || (OPTION_SET_P (flag_unroll_all_loops) && flag_unroll_all_loops))
{
- if (!OPTION_SET_P (unroll_only_small_loops))
- unroll_only_small_loops = 0;
- if (!OPTION_SET_P (flag_rename_registers))
- flag_rename_registers = 1;
if (!OPTION_SET_P (flag_cunroll_grow_size))
flag_cunroll_grow_size = 1;
}
diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt
index 9d7878f144a..faeb7423ca7 100644
--- a/gcc/config/rs6000/rs6000.opt
+++ b/gcc/config/rs6000/rs6000.opt
@@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1) Save
Analyze and remove doubleword swaps from VSX computations.
munroll-only-small-loops
-Target Undocumented Var(unroll_only_small_loops) Init(0) Save
+Target Undocumented Var(unroll_only_small_loops) Init(0) Save EnabledBy(funroll-loops)
; Use conservative small loop unrolling.
mpower9-misc
--
2.33.1
next prev parent reply other threads:[~2021-11-19 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 16:12 Martin Liska
2021-11-18 12:45 ` Martin Liška
2021-11-18 18:59 ` Segher Boessenkool
2021-11-19 11:32 ` Martin Liška
2021-11-19 11:43 ` Segher Boessenkool
2021-11-19 12:25 ` Martin Liška
2021-11-19 12:31 ` Martin Liška [this message]
2021-11-19 12:45 ` Segher Boessenkool
2021-11-19 12:57 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af44220e-4502-a9e7-a63b-80d6d11558d8@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).