From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 9D84B3858D35 for ; Tue, 4 Jul 2023 12:52:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D84B3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fbc54caad5so51095855e9.2 for ; Tue, 04 Jul 2023 05:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688475134; x=1691067134; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vm8NLhwJljlExPedT2o2n3GrubeyFQT57uA8r3S8jI8=; b=K8vpWSOXMcJLtj/dRXWccPJF6Fq6B2XedF7j7OWCkERZYGjiHdtbd2zs5WcBgzrhqA Gn4Rdf77585AE3M411UAtCIT3PlM4VIw/gK/JJ5UuSflzF+j66p9OMGeYb5ALxFC3vJL GVrY+z3AfzKhA4KvlqudM44P4LaR9NWJZTUWVe+x7RXbKapsP/E0cbkAUw7DrPfq+2rC mu33n7rwpDbcSIAdvMNBxwf7fTdLQUHKbuy3NKQGr99lNFl9GlB7rfa4SaLCtDZ/rxs+ ck9K1Quf9y8IxVzjS4BXQe8WBB2oPHdWf45WSWhF7yPgyF62HkpINUMh+QeGkf4AorPh AlSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688475134; x=1691067134; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vm8NLhwJljlExPedT2o2n3GrubeyFQT57uA8r3S8jI8=; b=B0FDWiyH61KXSkLO7TXoc8lN2QhFgRKecc6T/DinKJ5zQIckyYz6e+JqhRyBaTb48R FkcI/erkF3P9pmkcE7aRUQ9ghWfXTSMAqNJYnuo2EbC/llGWi2IeRfDYc4WqUhUAoOg/ Q9UZXdomXmKri4LKcDZc3Owsz2MqSsMgHqEyjxEUyQ0hGqulH3FXN0NcDMVZVzPrC6j9 K7C3JwiHMb4Xm84t+SejhS4fcRdu2p9UqfDwuzFPPXsU0puUuSzID7nEvfpRdcdqtrNE wKp09nrigPs7lHkOIbcskTHOP4rtOAHMqNc8crb0zADFCv6bTqTO0zeMv3i56ZrIgF2D k5QA== X-Gm-Message-State: AC+VfDyhKNk4u4loB0qOM+uaDDw80WDmwFvrZ1bVywwgoBvVWNYGfTuK CLLU6NTesRY3uP+76whI8Dk= X-Google-Smtp-Source: ACHHUZ7aJ8usiIHy7Jc+ESWi7Gg7RZVqszpLyP9XZzc8Nq9XyOmuIYdw5SE+niUhasgniZA8NmDeBw== X-Received: by 2002:a05:600c:3787:b0:3fb:ac73:f7d9 with SMTP id o7-20020a05600c378700b003fbac73f7d9mr10259749wmr.32.1688475134075; Tue, 04 Jul 2023 05:52:14 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id o11-20020a05600c378b00b003fa95f328afsm25368788wmr.29.2023.07.04.05.52.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 05:52:13 -0700 (PDT) Message-ID: Date: Tue, 4 Jul 2023 14:52:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, jeffreyalaw@gmail.com, yanzhang.wang@intel.com, kito.cheng@gmail.com Subject: Re: [PATCH v2] RISC-V: Fix one bug for floating-point static frm Content-Language: en-US To: pan2.li@intel.com, gcc-patches@gcc.gnu.org References: <20230704080806.2677374-1-pan2.li@intel.com> From: Robin Dapp In-Reply-To: <20230704080806.2677374-1-pan2.li@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Pan, I only just now got back to my mails and I'm a bit confused about the several patches related to rounding mode. > 1. By default, the RVV floating-point will take dyn mode. Here you are referring to 10.1 in the spec I assume. Could we add this as a comment in the code? > 2. DYN is invalid in FRM register for RVV floating-point. What does that mean or rather how is that reflected in the code? > - return code >= 0 ? get_attr_frm_mode (insn) : FRM_MODE_NONE; > + return code >= 0 ? get_attr_frm_mode (insn) : FRM_MODE_DYN; This still has yesterday's bug right? I.e. get_attr_frm_mode returns 5 for dyn instead of 7 because the enums don't match (leading to SIGILL). > +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-insert-6.c > @@ -0,0 +1,31 @@ > +/* { dg-do compile } */ > +/* { dg-options "-march=rv64gcv -mabi=lp64 -O3 -Wno-psabi" } */ I would prefer to have an execution test here as well. Even though we likely FAIL in other tests when the rounding mode is off, it would be good to have a specific one. Maybe it doesn't exactly fit into this patch but in general. Regards Robin