From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C18F23858407 for ; Wed, 25 Jan 2023 14:09:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C18F23858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674655744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H0FF8Tqn/HiUFfze8GWkyzetM4rFgZ9APJam1M4HXNM=; b=KXDTGJ7DVvgdUHZS/715m5RK9x43pkDquDg/+1cnSb43sz5SvI8S8o3xN7gIjxGYmbI6w4 DfjL3jX+ZQvFd1mfTt66Sev0FqN+bOxC/ZlXyqCilunkWyqbuR8CjCbusU4mbiFWEs0p0l y0TqXcc/qPObGan4py5HMqCWKe7VHe0= Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-549-7tNuBR1kMwasVT6Rq2aO-w-1; Wed, 25 Jan 2023 09:09:03 -0500 X-MC-Unique: 7tNuBR1kMwasVT6Rq2aO-w-1 Received: by mail-yb1-f198.google.com with SMTP id n203-20020a2572d4000000b0078f09db9888so19871010ybc.18 for ; Wed, 25 Jan 2023 06:09:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H0FF8Tqn/HiUFfze8GWkyzetM4rFgZ9APJam1M4HXNM=; b=31c8Pr7rm2INGUDXtWHTbUbY6zR+JM9kbci/dPdCSsZnxRtYs6sF3E8SsrGcH+oCpJ TEm4xu7yhs3OoYa8AdecYEolNYareNotj9aRJeb9+PPBObYoCF7b/F0m6tsMPnHPRL9m U5t/SknlBF0P2TWpKtyfui4PacMxbya6e6iGEvjgcH3ojiIqcrf6w4N6IEDIUO8/PAOr vE5FkmMRtuivaZrxwapswihkHeVssyKFckEXUYsucnEC43/ss5pz45rcpu2/dYFKOfSW Y3+A2HeHoIUG8CiUNtMVTYnmOgumyTg6ArJqxAzQZYnLCqluXsS3qwXuMvJ5zIAMv2r3 zoNQ== X-Gm-Message-State: AO0yUKVRJp8sMl5LAn4ILYS3B8RJVnWZmneUkqjhThc61KxQj4cpiGW7 weJS5Ob2B/jbwPcirdjwlYuSt7nBRUjXahGEVrSabg4uBjWYzTLmxxZvtGBfDyAVVN9Z1PGO/5j q+dVnd8mYIt7maCwVpw== X-Received: by 2002:a81:b306:0:b0:506:31ca:b3c1 with SMTP id r6-20020a81b306000000b0050631cab3c1mr5502609ywh.52.1674655742553; Wed, 25 Jan 2023 06:09:02 -0800 (PST) X-Google-Smtp-Source: AK7set+Yo91MQXZJS1KRW2OdTUzXNe7xMw5lU/D94N2T/0s3PCB90+f3n1R7sKoZuQS/nac81tYpfg== X-Received: by 2002:a81:b306:0:b0:506:31ca:b3c1 with SMTP id r6-20020a81b306000000b0050631cab3c1mr5502589ywh.52.1674655742245; Wed, 25 Jan 2023 06:09:02 -0800 (PST) Received: from [192.168.1.108] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id q19-20020a37f713000000b006fc9fe67e34sm3510282qkj.81.2023.01.25.06.09.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 06:09:01 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 09:09:00 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [committed] testsuite: Fix up new51.C test on various targets [PR108533] To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20230124032614.121085-1-jason@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/24/23 18:16, Jakub Jelinek wrote: > On Mon, Jan 23, 2023 at 10:26:14PM -0500, Jason Merrill via Gcc-patches wrote: >> * g++.dg/init/new51.C: New test. > > The test fails on targets where size_t is not unsigned long > due to extra diagnostics. > > As the testcase is tested in C++98 too, I'm not using decltype (sizeof 0) > but __SIZE_TYPE__. > > Tested on x86_64-linux and i686-linux (plus verified with older snapshots > that it ICEs even with the change with both -m32/-m64), committed to > trunk as obvious. Thanks. > 2023-01-25 Jakub Jelinek > > PR c++/107329 > PR testsuite/108533 > * g++.dg/init/new51.C (size_t): New typedef. > (RexxClass::operator new, RexxClass::operator delete): Use size_t > instead of unsigned long. > > --- gcc/testsuite/g++.dg/init/new51.C.jj 2023-01-24 11:10:13.000000000 +0100 > +++ gcc/testsuite/g++.dg/init/new51.C 2023-01-25 00:05:10.767472447 +0100 > @@ -1,9 +1,10 @@ > // PR c++/107329 > > +typedef __SIZE_TYPE__ size_t; > struct RexxClass { > - void *operator new(unsigned long, unsigned long, const char *, RexxClass *, > + void *operator new(size_t, size_t, const char *, RexxClass *, > RexxClass *); > - void operator delete(void *, unsigned long, const char *, RexxClass *, > + void operator delete(void *, size_t, const char *, RexxClass *, > RexxClass *); > RexxClass(); > }; > > Jakub >