From: Jeff Law <jeffreyalaw@gmail.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Kito Cheng <kito.cheng@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RISC-V: Deduplicate #error messages in testsuite
Date: Thu, 17 Aug 2023 07:53:14 -0600 [thread overview]
Message-ID: <af81a424-f911-eddb-1409-22b57c2d6f62@gmail.com> (raw)
In-Reply-To: <89ded79ffaf3c2c5e3a6d35ee082a40de645f8f6.1691981620.git.research_trasio@irq.a4lg.com>
On 8/13/23 20:53, Tsukasa OI via Gcc-patches wrote:
> From: Tsukasa OI<research_trasio@irq.a4lg.com>
>
> "#error Feature macro not defined" is required to test the existence of an
> extension through the preprocessor. However, multiple occurrence of the
> exact same error message will confuse the developer once an error is
> encountered.
>
> This commit replaces such error messages to
> "#error Feature macro for `EXT' not defined" to make which
> macro is missing.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/zvkn.c: Deduplicate #error messages.
> * gcc.target/riscv/zvkn-1.c: Ditto.
> * gcc.target/riscv/zvknc.c: Ditto.
> * gcc.target/riscv/zvknc-1.c: Ditto.
> * gcc.target/riscv/zvknc-2.c: Ditto.
> * gcc.target/riscv/zvkng.c: Ditto.
> * gcc.target/riscv/zvkng-1.c: Ditto.
> * gcc.target/riscv/zvkng-2.c: Ditto.
> * gcc.target/riscv/zvks.c: Ditto.
> * gcc.target/riscv/zvks-1.c: Ditto.
> * gcc.target/riscv/zvksc.c: Ditto.
> * gcc.target/riscv/zvksc-1.c: Ditto.
> * gcc.target/riscv/zvksc-2.c: Ditto.
> * gcc.target/riscv/zvksg.c: Ditto.
> * gcc.target/riscv/zvksg-1.c: Ditto.
> * gcc.target/riscv/zvksg-2.c: Ditto.
Pushed to the trunk. Thanks.
jeff
next prev parent reply other threads:[~2023-08-17 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 2:53 Tsukasa OI
2023-08-17 13:53 ` Jeff Law [this message]
2023-08-18 3:52 ` [PATCH 1/2] RISC-V: Add quotes to #error messages Tsukasa OI
2023-08-21 13:32 ` Jeff Law
2023-08-18 3:52 ` [PATCH 2/2] RISC-V: Add quotes to #error messages (all) Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af81a424-f911-eddb-1409-22b57c2d6f62@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).