From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 4B16B3858D20 for ; Fri, 20 Oct 2023 14:33:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B16B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B16B3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697812406; cv=none; b=gaAnyCPKmH27kxpJnt5WliEnbKLOGWL89QYTSAZwmx9RiuO+h8ZN3hu01KQbQ10QZx5oAjDjKm8GIptgDcnQxbKFExQV01NmDf9UvXfjudLbuxOX9Dic8aMmH223r9wK5LPxfiSF02fqmhl9iIo1L40z9UGi4QRCg2WpM7ZgMWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697812406; c=relaxed/simple; bh=sxcuXcIi5rUZwMhEAFQhuPWHhCm6cDvdUJd7pzqeJ48=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZSLnEvqqPVCVCE0zudRQtD1N51ru4d/+aUdXhi0EWbpT8YXrfGyMu/rjY6LFKac5cbWIARIV+rEhljfz5Lv/SZ+c7/TUPxQJg/H0mTb+gE4xYnQlI8CtiwvKjkpabgeMxRl9cIpcTNQJm5gomqjxfN1mj7p4MZOphHdDCQE0f3E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1c9a1762b43so7183085ad.1 for ; Fri, 20 Oct 2023 07:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697812402; x=1698417202; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DN1Tz22V6aNh7bhKGas3AVBlKiMiWJf4MkqxpppTrnc=; b=S8VHVRLGnl09ludNMdbnfzWrmb638e7jwZOGFYGVcMgzjbL9oz8AVT06gsH6MiLPfy PVrXe6lhHTHOLUkLhzA9DwJlliancCK7c9O69cRWqbIRYiyc/1/xw0WAh+0yMzffTKr2 nvdSAiAzO9xqYtZLcbkxt5i9I9I+WLrLjGyojUhcNmpNcsi2otq3CUy5lLQrRLan8Jql gLxCgTXsRkPBGTTGDo6Hh++BFicoYEJ6pmYOnHkWBlLxg6a3QpZHisriEMiRMk/5U7cG IiIxig7OEpH4z232HRIAgSN3/+yCeaf1mkkdemXVsLMS4Nlaa5k9tbuB7prLUPrJ9Dwr epIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697812402; x=1698417202; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DN1Tz22V6aNh7bhKGas3AVBlKiMiWJf4MkqxpppTrnc=; b=OQJqy7q/AGwG0oNeuM63JPHe+Cs/L2FknWFdHmdsRKy1uy9sio01QmkgUlHuIjuyOK Aei7I/9a+y3QrskV+eejd+SpepaQQ1CbTSsiL3Fbe4sJ6SlyCbgECypK+wqbwL+oc61+ SbBdqp8H7PH8ngucV5C3O68+sUoPtQuHdpCFkkEX1QFTg6DXm1SEUZISzR0pIb8A9n+g nCpZmEwHy/crZ5L8J3I/801xxEZd2wZG5HFcki2f6YlnNTqUoEjfMLlH0RSXFpQPwE8w qwobJTxZbF6ngLrgIsqCz8j9n3i1P1AVnBhjNwoZ4jeFqv33mAwV53+Gbz7evL5tgKll tPPw== X-Gm-Message-State: AOJu0Ywj57Ta3t0DuhTpFS9XXiSyCwMrkFeTZL6gt5h1nDGGFJYXSTZW gC+KkJwD6yAk4yxJHuuRKSgIOigePb8= X-Google-Smtp-Source: AGHT+IE1xh7+DL64qJpeblLqVuK6zKwRhqCut9sPKU6yUc8WA8QwjeBLLYkcRHwguMGqBafBQ5ZbgA== X-Received: by 2002:a17:902:e88f:b0:1c7:23c9:a7db with SMTP id w15-20020a170902e88f00b001c723c9a7dbmr1804832plg.26.1697812401915; Fri, 20 Oct 2023 07:33:21 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id jb12-20020a170903258c00b001c46d04d001sm1613438plb.87.2023.10.20.07.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Oct 2023 07:33:21 -0700 (PDT) Message-ID: Date: Fri, 20 Oct 2023 08:33:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] riscv: Adding support for XTHead(F)MemIdx Content-Language: en-US To: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich References: <20231020095348.2455729-1-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20231020095348.2455729-1-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/20/23 03:53, Christoph Muellner wrote: > From: Christoph Müllner > > This two patches add support for the XTheadMemIdx > and XTheadFMemIdx ISA extensions, that support additional > addressing modes. The extensions are implemented in a range > of T-Head cores (e.g. C906, C910, C920) and are available > on the market for quite some time. > > The ISA spec can be found here: > https://github.com/T-head-Semi/thead-extension-spec > > An initial version of these patches has been sent a while ago. > Jeff Law suggested to use INSNs instead of peepholes to let > the combiner do the optimization. This is the major change > that this patches have seen. Did you happen to do any before/after testing? And if so, did using the combiner help with discovery of these cases? I would expect it to have done so, but it's always nice to have a confirmation. If not, no big deal from a review standpoint. Given I looked at these before, I'll take this small kit again. Jeff