From: Aldy Hernandez <aldyh@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [COMMITTED 2/4] - Remove tree_code from range-operator.
Date: Fri, 9 Jun 2023 10:36:34 +0200 [thread overview]
Message-ID: <af8782b4-1e64-cc25-783a-a897eab0ea86@redhat.com> (raw)
In-Reply-To: <f4fbb34c-a042-6704-a615-a75f5a32df6c@redhat.com>
On 6/8/23 20:57, Andrew MacLeod wrote:
> Range_operator had a tree code added last release to facilitate bitmask
> operations. This was intended to be a temporary change until we could
> figure out something more strategic going forward.
>
> This patch removes the tree_code and replaces it with a virtual routine
> to perform the masking. Each of the affected tree codes operators now
> call the bitmask routine via a virtual function. At some point we may
> want to consolidate the code that CCP is using so that it resides in the
> range_operator, but the extensive parameter list used by that CCP
> routine makes that prohibitive to do at the moment.
It's on my radar for this release. I will be changing the
nonzero_bitmask field in irange for a value/mask pair, as CCP does, and
if all goes well, consolidating CCP as well as the on-the-side bitmask
tracking IPA does.
Thanks for tidying this up.
Aldy
prev parent reply other threads:[~2023-06-09 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 18:57 Andrew MacLeod
2023-06-09 8:36 ` Aldy Hernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af8782b4-1e64-cc25-783a-a897eab0ea86@redhat.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).