From: Jeff Law <jeffreyalaw@gmail.com>
To: Florian Weimer <fweimer@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror
Date: Mon, 13 Nov 2023 12:25:45 -0700 [thread overview]
Message-ID: <af95db61-db8f-4d8e-8eea-7b5b10aefb0a@gmail.com> (raw)
In-Reply-To: <7f561d1416464a4ddd3304475218688a2ffd3ea8.1699879818.git.fweimer@redhat.com>
On 11/13/23 06:10, Florian Weimer wrote:
> In the future, it may make sense to avoid cascading errors from
> the implicit declaration, especially its assumed int return type.
> This change here only changes the kind of the diagnostic, not
> its wording or consequences.
>
> gcc/c/
>
> * doc/invoke.texi (Warning Options): Document changes.
>
> gcc/c/
>
> * c-decl.cc (implicit_decl_pedpermerror): Rename from
> implicit_decl_warning. Call pedpermerror instead of
> pedwarn and warning_at.
> (implicitly_declare): Adjust callers.
>
> gcc/testsuite/
>
> * c-c++-common/spellcheck-reserved.c (test, test_2): Expect
> error instead of warning.
> (f): Expect error instead of warning.
> * gcc.dg/Wimplicit-function-declaration-c99.c: Compile with
> -fpermissive due to expected warning.
> * gcc.dg/Wimplicit-function-declaration-c99-2.c: New test.
> Copied from gcc.dg/Wimplicit-function-declaration-c99.c.
> Expect error.
> * gcc.dg/missing-header-fixit-1.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-1a.c: New test. Copied from
> gcc.dg/missing-header-fixit-1.c, but expect error.
> * gcc.dg/missing-header-fixit-2.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-2a.c: New test. Copied from
> gcc.dg/missing-header-fixit-2.c, but expect error.
> * gcc.dg/missing-header-fixit-4.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-4a.c: New test. Copied from
> gcc.dg/missing-header-fixit-4.c, but expect error.
> * gcc.dg/missing-header-fixit-5.c: Compile with -fpermissive
> due to expect error.
> * gcc.dg/missing-header-fixit-5a.c: New test. Copied from
> gcc.dg/missing-header-fixit-5.c, but expect error.
> * gcc.dg/pr61852.c: Expect implicit-function-declaration
> error instead of warning.
> * gcc.dg/spellcheck-identifiers-2.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-2a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
> * gcc.dg/spellcheck-identifiers-3.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-3a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect errors.
> * gcc.dg/spellcheck-identifiers-4.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-4a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers-2a.c. Expect error.
> * gcc.dg/spellcheck-identifiers.c: Compile with
> -fpermissive due to expected warnings.
> * gcc.dg/spellcheck-identifiers-1a.c: New test. Copied
> from gcc.dg/spellcheck-identifiers.c. Expect errors.
> * gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c (f1):
> Expect error.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c:
> (f1): Likewise.
> * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c:
> (f1): Likewise.
> ---
OK
jeff
next prev parent reply other threads:[~2023-11-13 19:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 13:09 [PATCH 0/6] Turn some C warnings into errors by default Florian Weimer
2023-11-13 13:09 ` [PATCH 1/6] c-family: Introduce pedpermerror Florian Weimer
2023-11-13 19:22 ` Jeff Law
2023-11-14 7:39 ` Florian Weimer
2023-11-13 13:10 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Florian Weimer
2023-11-13 19:24 ` Jeff Law
2023-11-13 19:44 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416] Sam James
2023-12-01 11:29 ` [PATCH 2/6] c: Turn int-conversion warnings into permerrors Thomas Schwinge
2023-12-01 11:36 ` Florian Weimer
2023-11-13 13:10 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror Florian Weimer
2023-11-13 19:25 ` Jeff Law [this message]
2023-11-13 19:42 ` [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092] Sam James
2023-11-13 13:11 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror Florian Weimer
2023-11-13 19:26 ` Jeff Law
2023-11-13 19:45 ` [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror [PR91093] Sam James
2023-11-13 13:11 ` [PATCH 5/6] c: Turn -Wreturn-mismatch into a pedpermerror Florian Weimer
2023-11-13 19:28 ` Jeff Law
2023-11-13 13:11 ` [PATCH 6/6] c: Turn -Wincompatible-pointer-types " Florian Weimer
2023-11-13 19:30 ` Jeff Law
2023-11-13 19:44 ` [PATCH 0/6] Turn some C warnings into errors by default Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af95db61-db8f-4d8e-8eea-7b5b10aefb0a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).