From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 69DA6381B3C5 for ; Mon, 13 Nov 2023 19:25:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69DA6381B3C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 69DA6381B3C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699903550; cv=none; b=Gt2FvvCvEv++R8cTzlSk9eB9p/k2zkE0zweW4hQq1iyEWeM+yKPpRLkByYMnBRYsPq2bFy5yEi0oun047erh3YL2SuLJHf+yVoAmcq6ke8g6GzyW8vNMDPeJAK6TGsquUcmGalX/3WfX1VWGLahpAi83CFeNo+jg7U96ai4Pas0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699903550; c=relaxed/simple; bh=0E4eyYB3abUmUUb+ctMAP6MyjQKmRBSdCeMDCWed9Ms=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=p7BsVYOqV8qrhDYaq1yGp6Bok3AEDnJ7/7lVB9Qzp1pheZysFQ5brbEbZii7IDYeqDBPy1LDngfMBV/fqZaZcam+vqLt6Sbs67aHhd3/XrpYBqQuwX+OU/rvxrZekeCByaZIL1ealdkKVrgQvO/LpqD/8326MIi7hukVa3UqIrY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1ce28faa92dso10304465ad.2 for ; Mon, 13 Nov 2023 11:25:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699903547; x=1700508347; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TqqJ+3IthM/2Wv1Rh0Ivp/gdatfsgb/AagSqPFoFt6A=; b=lRIN0z7E9J2DKGx3+gfohYPrHbAN0eIgIf1qXI696C1VN+sI0HCPOFXTUUw8z/CCiM 8/zC31xcDP3N/oTezE3RqZiBo2HOtvUKo5bwAq6hJ8HWLiRJL+7iSY6OkCohazoCX76R WXk6wsWN4mXYw8aK575JSGHpmHC/d5stguKqmpJcfLmkQARmsMJm8koU3gS5LqGGczmH hFH9y5QoeBl49rYdwzZSp6g9qTJj6jVrsntpYUbqiap4q31lRJ3QtaSWgvP793PTCIw4 Sy+JHR+SOMby4xbgLN5ba7rgVR+/TJ5X4/mehvFJE1o7MJdGO1n3AkrSDaflMzEgb1Gy mmVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699903547; x=1700508347; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TqqJ+3IthM/2Wv1Rh0Ivp/gdatfsgb/AagSqPFoFt6A=; b=ijx8fshz1YEjhPvPDEAJ6QLjYNoQnFomOf8w5DpcELQf7hiv6N1IotPytRUs+j81Fr xyoE7o/WqViOhucifMAlxWZX6+WpDioyOQ14qV4HRFm8yvvGaUkbw54Nx4X+fKo98pCE LyJnqmx6XgAnJmcSVXuJpKmJd4jSkCy5UHHPsyImOs17VXWqXi6IAyT7C21oeQ0vi+bP NyR7g61/bFOc41buAfJ5hAgLTNR+uvsVGrlTH53mCt65dTST4IMW8ev96y6wBizbjww4 WWStJuhhmZqwFls5EwQSMThfIKgZJt6cyRec4+UkK52gHJFnwsCkXv8U1xLREpnySYIv wgmQ== X-Gm-Message-State: AOJu0Yw3UGdsdgRcTuNCA1qSJS8p7LwL0+2pSkS4I2yA1QfulzJQF/8l HSNLtfjH/nU3bLPNdFipcPhCHJ9bK0ctZA== X-Google-Smtp-Source: AGHT+IGCeToje8sLpSnCFcq8ChFl5goniEKzZEPyDNFEpYeDT+CM1CyXGiXASYprdNZE2sm+Q+2izg== X-Received: by 2002:a17:903:4d0:b0:1cc:70dd:62c3 with SMTP id jm16-20020a17090304d000b001cc70dd62c3mr147132plb.30.1699903547357; Mon, 13 Nov 2023 11:25:47 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id h4-20020a170902748400b001c5d09e9437sm4332452pll.25.2023.11.13.11.25.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 11:25:46 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 12:25:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror Content-Language: en-US To: Florian Weimer , gcc-patches@gcc.gnu.org References: <7f561d1416464a4ddd3304475218688a2ffd3ea8.1699879818.git.fweimer@redhat.com> From: Jeff Law In-Reply-To: <7f561d1416464a4ddd3304475218688a2ffd3ea8.1699879818.git.fweimer@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/13/23 06:10, Florian Weimer wrote: > In the future, it may make sense to avoid cascading errors from > the implicit declaration, especially its assumed int return type. > This change here only changes the kind of the diagnostic, not > its wording or consequences. > > gcc/c/ > > * doc/invoke.texi (Warning Options): Document changes. > > gcc/c/ > > * c-decl.cc (implicit_decl_pedpermerror): Rename from > implicit_decl_warning. Call pedpermerror instead of > pedwarn and warning_at. > (implicitly_declare): Adjust callers. > > gcc/testsuite/ > > * c-c++-common/spellcheck-reserved.c (test, test_2): Expect > error instead of warning. > (f): Expect error instead of warning. > * gcc.dg/Wimplicit-function-declaration-c99.c: Compile with > -fpermissive due to expected warning. > * gcc.dg/Wimplicit-function-declaration-c99-2.c: New test. > Copied from gcc.dg/Wimplicit-function-declaration-c99.c. > Expect error. > * gcc.dg/missing-header-fixit-1.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-1a.c: New test. Copied from > gcc.dg/missing-header-fixit-1.c, but expect error. > * gcc.dg/missing-header-fixit-2.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-2a.c: New test. Copied from > gcc.dg/missing-header-fixit-2.c, but expect error. > * gcc.dg/missing-header-fixit-4.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-4a.c: New test. Copied from > gcc.dg/missing-header-fixit-4.c, but expect error. > * gcc.dg/missing-header-fixit-5.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-5a.c: New test. Copied from > gcc.dg/missing-header-fixit-5.c, but expect error. > * gcc.dg/pr61852.c: Expect implicit-function-declaration > error instead of warning. > * gcc.dg/spellcheck-identifiers-2.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-2a.c: New test. Copied > from gcc.dg/spellcheck-identifiers-2a.c. Expect errors. > * gcc.dg/spellcheck-identifiers-3.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-3a.c: New test. Copied > from gcc.dg/spellcheck-identifiers-2a.c. Expect errors. > * gcc.dg/spellcheck-identifiers-4.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-4a.c: New test. Copied > from gcc.dg/spellcheck-identifiers-2a.c. Expect error. > * gcc.dg/spellcheck-identifiers.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-1a.c: New test. Copied > from gcc.dg/spellcheck-identifiers.c. Expect errors. > * gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c (f1): > Expect error. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c: > (f1): Likewise. > --- OK jeff