From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id E112D3857C46 for ; Wed, 7 Sep 2022 17:02:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E112D3857C46 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x636.google.com with SMTP id t3so10138040ply.2 for ; Wed, 07 Sep 2022 10:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=chsFY/TK9OBG2fzUs3IciO0UvtwSBfrviItWKLHJaLA=; b=ooKyV3+f26WLmmMcBzeeQ/etkoiC6vST9qjo4J3sgDoSlzOI5SOCe7x7BmAx7H52ea oae7+GQIjppE3R/6+jrlqn0GNtGvLEoeVguA09Ty1DsYr3Bam99fCZQaEOJrd5lDbhXX Aun+7v63etrX6IrU5Er42E2K5jYyUho+19bQogHZqckBK2voVr1ctUvMatfAI9X6NWn0 IymomRZeqg6G8fmX9HUP4GDtCQz+FhbZtZQq6clhgPMkro55XfEsMy9rstnSAak1+RX1 uY9sYW4ScuUmLcDzZrocYx15odpXXQZr50uL4kQyG+L5gItvSvZsPMxMspVwBCpJUV+3 rG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=chsFY/TK9OBG2fzUs3IciO0UvtwSBfrviItWKLHJaLA=; b=lVEe4hbRcYZ7uRP8Leh6KFgu9giMsE8aR5MPWxEvKeRkaJq+oXYU9VYXZ0lUODOSx+ glbHCnz+CNQ8hRfCq3oetV8qQkKIoEN6v2KTRVrqaWALk3MicIXQtdkuAEXZIQwWRGTq 5k/XS13T0LsR9nCPWf1yIuswdz+LI3bzp/vNcwU1Wkb2vNy9aWzGsdPFyitw3HuQk7MC IZQshPQBQZ6njXPaqeV49g40vUEucQ3smZnWGirTIFvcfeGzm/IgvkkYXXE2lt3qPOCD xWVVf+m1ML4zCp5XWRkjOOBnywiRP5HG5QtgQnEBHtNWTFTzrpKHxnHq4K6L0IOdsj2L NdAw== X-Gm-Message-State: ACgBeo2+laTEYms3xNI71Q8dlKuT8F3/zgfk7Va6aGwXEpG7MLkE5Vjy zB4pxtpiVvcOscynwpI1JV7VWen8DcWfcg== X-Google-Smtp-Source: AA6agR6qgo8079cLddyjYeXvNNQjhDQY2QDqufPEupw1y4AGtZuQwvnnq5EWIQ9JYu47eEokq9LlCQ== X-Received: by 2002:a17:90a:9f96:b0:1fa:b4fb:6297 with SMTP id o22-20020a17090a9f9600b001fab4fb6297mr5056387pjp.80.1662570178068; Wed, 07 Sep 2022 10:02:58 -0700 (PDT) Received: from [172.31.0.204] (c-73-98-188-51.hsd1.ut.comcast.net. [73.98.188.51]) by smtp.gmail.com with ESMTPSA id q18-20020a170902bd9200b00174fa8cbf3dsm12401458pls.157.2022.09.07.10.02.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Sep 2022 10:02:57 -0700 (PDT) Message-ID: Date: Wed, 7 Sep 2022 11:02:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] Ignore debug insns with CONCAT and CONCATN for insn scheduling Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220902143639.2464892-1-hjl.tools@gmail.com> From: Jeff Law In-Reply-To: <20220902143639.2464892-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/2/2022 8:36 AM, H.J. Lu via Gcc-patches wrote: > CONCAT and CONCATN never appear in the insn chain. They are only used > in debug insn. Ignore debug insns with CONCAT and CONCATN for insn > scheduling to avoid different insn orders with and without debug insn. > > gcc/ > > PR rtl-optimization/106746 > * sched-deps.cc (sched_analyze_2): Ignore debug insns with CONCAT > and CONCATN. Shouldn't we be ignoring everything in a debug insn?   I don't see why CONCAT/CONCATN are special here. jeff