From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 4.mo576.mail-out.ovh.net (4.mo576.mail-out.ovh.net [46.105.42.102]) by sourceware.org (Postfix) with ESMTPS id 7A6493858C27 for ; Wed, 13 Oct 2021 15:42:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A6493858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lsferreira.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lsferreira.net Received: from player737.ha.ovh.net (unknown [10.109.146.143]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 7617422AFE for ; Wed, 13 Oct 2021 15:42:35 +0000 (UTC) Received: from lsferreira.net (252.131.62.94.rev.vodafone.pt [94.62.131.252]) (Authenticated sender: contact@lsferreira.net) by player737.ha.ovh.net (Postfix) with ESMTPSA id C48DB19B88125 for ; Wed, 13 Oct 2021 15:42:34 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-100R00368eb1737-e897-43f6-92a0-8197078c102e, A8D098B9B29251AE790F9592EC533D14122901BA) smtp.auth=contact@lsferreira.net X-OVh-ClientIp: 94.62.131.252 Message-ID: Subject: Re: [PATCH] libiberty: d-demangle: use distinguishable tuple() From: =?ISO-8859-1?Q?Lu=EDs?= Ferreira Reply-To: lsferreira@riseup.net To: gcc-patches@gcc.gnu.org Date: Wed, 13 Oct 2021 16:42:27 +0100 In-Reply-To: <20211013153459.160132-1-contact@lsferreira.net> References: <20211013153459.160132-1-contact@lsferreira.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-s7poBG/7l41VSvlbSzNt" User-Agent: Evolution 3.40.4 MIME-Version: 1.0 X-Ovh-Tracer-Id: 18332746710419699735 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddgledtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefkuffhrhfvffgjfhgtfgggsehgtderredtreejnecuhfhrohhmpefnuhovshcuhfgvrhhrvghirhgruceotghonhhtrggttheslhhsfhgvrhhrvghirhgrrdhnvghtqeenucggtffrrghtthgvrhhnpedvieejkeefleetheejjefhtdfffeefteegjeevleetteevjeefgeefkeevheduffenucffohhmrghinheplhhsfhgvrhhrvghirhgrrdhnvghtnecukfhppedtrddtrddtrddtpdelgedriedvrddufedurddvhedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeefjedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtohhnthgrtghtsehlshhfvghrrhgvihhrrgdrnhgvthdprhgtphhtthhopehgtggtqdhprghttghhvghssehgtggtrdhgnhhurdhorhhg X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 15:42:37 -0000 --=-s7poBG/7l41VSvlbSzNt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2021-10-13 at 16:34 +0100, Lu=C3=ADs Ferreira wrote: > Since Tuple!() is templated type from standard library, this can make > two > demangled names undistinguishable. >=20 > Signed-off-by: Lu=C3=ADs Ferreira >=20 > libiberty/ChangeLog: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* d-demangle.c (dlang_par= se_tuple): use tuple() instead of > Tuple!() > --- > =C2=A0libiberty/d-demangle.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libiberty/d-demangle.c b/libiberty/d-demangle.c > index 880f2ec85a4..5dbdc36adbe 100644 > --- a/libiberty/d-demangle.c > +++ b/libiberty/d-demangle.c > @@ -1711,7 +1711,7 @@ dlang_parse_tuple (string *decl, const char > *mangled, struct dlang_info *info) > =C2=A0=C2=A0 if (mangled =3D=3D NULL) > =C2=A0=C2=A0=C2=A0=C2=A0 return NULL; > =C2=A0 > -=C2=A0 string_append (decl, "Tuple!("); > +=C2=A0 string_append (decl, "tuple("); > =C2=A0 > =C2=A0=C2=A0 while (elements--) > =C2=A0=C2=A0=C2=A0=C2=A0 { I need to update tests --=20 Sincerely, Lu=C3=ADs Ferreira @ lsferreira.net --=-s7poBG/7l41VSvlbSzNt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE0nPfaWPZzvrMTlSVcwdQ1Ut6n2YFAmFm/mMACgkQcwdQ1Ut6 n2YF4Q//bxRLX7ucMu1cUZa6C8I3TGJtXolLz5ArgGiqEhQjN+P7ouV4a26mVUCL zx8QEHunGJocxtefHD26BDnqZ0xf5i3128Ci6HxyWI5lGsXJb4qHTUMCB24LY+YK 9JbOHmZG2lxbp5Ik+P86KvrRIRB7M42CENY9rfJU0mcvluUKW8Z2eCNVTJSP3NJi k9GzPvf1j7NCw1SVMDHfuoZIytNOIZJxsuTRPpFCyJhmrzTFCjlPzJABW7XpJKsc 0Tg08rClIz10gorp28gfceAp5PJHUd8Rw9lq9/JWYZk4fg8AQfded1bp8jLMQxzP 11n6+CNZxVdi/geUgrWjQtu4amZJIq2Bd3hWx3YNMYqx/be8B3xfaahp1fmeATsh YspXvmHBzkPLkPOGdz0LBlH8hs4pPxxKdvfvi2N0WPWuTR1CitH2tzRAnWRxDgbt qG2Gk1M5JdvXrgEoT68dCIeLh55p3FT00vy7CGGzRohnAk3WbAgAR/NcUgzmn3w1 ryTMp/j570Pt3t2LfGG7u40I46JRlcgrvdK0ZSJCc9gmFWn7okJ3GSx2WbPJD2ut DNL1UQSE0l77fvK0jLPyIpqeysq/421NvcYAvCRxu4cnTci2RKFTM+nUXPHa34T3 wD2g7lUnnXQQpOEu4b/l7q1FiKDdAYG8atWcaKGLZct0kGX6gcU= =JvUq -----END PGP SIGNATURE----- --=-s7poBG/7l41VSvlbSzNt--