* [PATCH] Install gcov-dump.
@ 2017-03-14 12:30 Martin Liška
2017-03-14 14:16 ` Richard Biener
2017-03-17 11:55 ` Tom de Vries
0 siblings, 2 replies; 8+ messages in thread
From: Martin Liška @ 2017-03-14 12:30 UTC (permalink / raw)
To: GCC Patches; +Cc: Richard Biener
[-- Attachment #1: Type: text/plain, Size: 87 bytes --]
Tested on my local machine that's properly installed.
Ready for trunk?
Thanks,
Martin
[-- Attachment #2: 0001-Install-gcov-dump.patch --]
[-- Type: text/x-patch, Size: 1650 bytes --]
From 553c8402f8b0c77a30f4476918de1e4acff34dbc Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Tue, 14 Mar 2017 13:26:49 +0100
Subject: [PATCH] Install gcov-dump.
gcc/ChangeLog:
2017-03-14 Martin Liska <mliska@suse.cz>
* Makefile.in: Install gcov-dump.
---
gcc/Makefile.in | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 8648d681fec..1ba0475c893 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -806,6 +806,7 @@ GCC_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo gcc|sed '$(progra
CPP_INSTALL_NAME := $(shell echo cpp|sed '$(program_transform_name)')
GCOV_INSTALL_NAME := $(shell echo gcov|sed '$(program_transform_name)')
GCOV_TOOL_INSTALL_NAME := $(shell echo gcov-tool|sed '$(program_transform_name)')
+GCOV_DUMP_INSTALL_NAME := $(shell echo gcov-dump|sed '$(program_transform_name)')
# Setup the testing framework, if you have one
EXPECT = `if [ -f $${rootme}/../expect/expect ] ; then \
@@ -3519,6 +3520,15 @@ install-common: native lang.install-common installdirs
gcov-tool$(exeext) $(DESTDIR)$(bindir)/$(GCOV_TOOL_INSTALL_NAME)$(exeext); \
fi; \
fi
+# Install gcov-dump if it was compiled.
+ -if test "$(enable_as_accelerator)" != "yes" ; then \
+ if [ -f gcov-dump$(exeext) ]; \
+ then \
+ rm -f $(DESTDIR)$(bindir)/$(GCOV_DUMP_INSTALL_NAME)$(exeext); \
+ $(INSTALL_PROGRAM) \
+ gcov-dump$(exeext) $(DESTDIR)$(bindir)/$(GCOV_DUMP_INSTALL_NAME)$(exeext); \
+ fi; \
+ fi
# Install the driver program as $(target_noncanonical)-gcc,
# $(target_noncanonical)-gcc-$(version), and also as gcc if native.
--
2.11.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Install gcov-dump.
2017-03-14 12:30 [PATCH] Install gcov-dump Martin Liška
@ 2017-03-14 14:16 ` Richard Biener
2017-03-14 17:31 ` Matthias Klose
2017-03-17 11:55 ` Tom de Vries
1 sibling, 1 reply; 8+ messages in thread
From: Richard Biener @ 2017-03-14 14:16 UTC (permalink / raw)
To: Martin Liška; +Cc: GCC Patches
On Tue, Mar 14, 2017 at 1:30 PM, Martin Liška <mliska@suse.cz> wrote:
> Tested on my local machine that's properly installed.
>
> Ready for trunk?
Ok.
Richard.
> Thanks,
> Martin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Install gcov-dump.
2017-03-14 14:16 ` Richard Biener
@ 2017-03-14 17:31 ` Matthias Klose
2017-03-15 10:19 ` Martin Liška
0 siblings, 1 reply; 8+ messages in thread
From: Matthias Klose @ 2017-03-14 17:31 UTC (permalink / raw)
To: Richard Biener, Martin Liška; +Cc: GCC Patches
On 14.03.2017 15:15, Richard Biener wrote:
> On Tue, Mar 14, 2017 at 1:30 PM, Martin Liška <mliska@suse.cz> wrote:
>> Tested on my local machine that's properly installed.
>>
>> Ready for trunk?
>
> Ok.
>
> Richard.
shouldn't that go to the active branches as well?
Matthias
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Install gcov-dump.
2017-03-14 17:31 ` Matthias Klose
@ 2017-03-15 10:19 ` Martin Liška
2017-03-15 13:49 ` Richard Biener
0 siblings, 1 reply; 8+ messages in thread
From: Martin Liška @ 2017-03-15 10:19 UTC (permalink / raw)
To: Matthias Klose, Richard Biener; +Cc: GCC Patches
On 03/14/2017 06:31 PM, Matthias Klose wrote:
> On 14.03.2017 15:15, Richard Biener wrote:
>> On Tue, Mar 14, 2017 at 1:30 PM, Martin Liška <mliska@suse.cz> wrote:
>>> Tested on my local machine that's properly installed.
>>>
>>> Ready for trunk?
>>
>> Ok.
>>
>> Richard.
>
> shouldn't that go to the active branches as well?
>
> Matthias
>
I would vote for that. However it may be bit strange that a new binary is added
in GCC 6.4.
What's maintainers' opinion about it?
Martin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Install gcov-dump.
2017-03-15 10:19 ` Martin Liška
@ 2017-03-15 13:49 ` Richard Biener
2017-03-16 22:45 ` Matthias Klose
0 siblings, 1 reply; 8+ messages in thread
From: Richard Biener @ 2017-03-15 13:49 UTC (permalink / raw)
To: Martin Liška, Matthias Klose; +Cc: GCC Patches
On March 15, 2017 11:19:24 AM GMT+01:00, "Martin Liška" <mliska@suse.cz> wrote:
>On 03/14/2017 06:31 PM, Matthias Klose wrote:
>> On 14.03.2017 15:15, Richard Biener wrote:
>>> On Tue, Mar 14, 2017 at 1:30 PM, Martin Liška <mliska@suse.cz>
>wrote:
>>>> Tested on my local machine that's properly installed.
>>>>
>>>> Ready for trunk?
>>>
>>> Ok.
>>>
>>> Richard.
>>
>> shouldn't that go to the active branches as well?
>>
>> Matthias
>>
>
>I would vote for that. However it may be bit strange that a new binary
>is added
>in GCC 6.4.
>
>What's maintainers' opinion about it?
No strong opinion but if Matthias would like to see it, fine.
Richard.
>Martin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Install gcov-dump.
2017-03-15 13:49 ` Richard Biener
@ 2017-03-16 22:45 ` Matthias Klose
0 siblings, 0 replies; 8+ messages in thread
From: Matthias Klose @ 2017-03-16 22:45 UTC (permalink / raw)
To: Richard Biener, Martin Liška, Matthias Klose; +Cc: GCC Patches
On 15.03.2017 14:49, Richard Biener wrote:
> On March 15, 2017 11:19:24 AM GMT+01:00, "Martin Liška" <mliska@suse.cz> wrote:
>> On 03/14/2017 06:31 PM, Matthias Klose wrote:
>>> On 14.03.2017 15:15, Richard Biener wrote:
>>>> On Tue, Mar 14, 2017 at 1:30 PM, Martin Liška <mliska@suse.cz>
>> wrote:
>>>>> Tested on my local machine that's properly installed.
>>>>>
>>>>> Ready for trunk?
>>>>
>>>> Ok.
>>>>
>>>> Richard.
>>>
>>> shouldn't that go to the active branches as well?
>>>
>>> Matthias
>>>
>>
>> I would vote for that. However it may be bit strange that a new binary
>> is added
>> in GCC 6.4.
>>
>> What's maintainers' opinion about it?
>
> No strong opinion but if Matthias would like to see it, fine.
now committed to the 5 and 6 branches.
Matthias
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Install gcov-dump.
2017-03-14 12:30 [PATCH] Install gcov-dump Martin Liška
2017-03-14 14:16 ` Richard Biener
@ 2017-03-17 11:55 ` Tom de Vries
2017-03-17 12:08 ` Richard Biener
1 sibling, 1 reply; 8+ messages in thread
From: Tom de Vries @ 2017-03-17 11:55 UTC (permalink / raw)
To: Martin Liška, GCC Patches; +Cc: Richard Biener
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On 14/03/17 13:30, Martin Liška wrote:
> Tested on my local machine that's properly installed.
>
> Ready for trunk?
I'm guessing there's an invariant that installed tools mention a bug url
with --help.
Using attached patch, we get:
...
$ gcov-dump --help
Usage: gcov-dump [OPTION] ... gcovfiles
Print coverage file contents
-h, --help Print this help
-v, --version Print version number
-l, --long Dump record contents too
-p, --positions Dump record positions
-w, --working-sets Dump working set computed from summary
For bug reporting instructions, please see:
<https://gcc.gnu.org/bugs/>.
...
OK for trunk, 5 and 6 branch?
Thanks,
- Tom
[-- Attachment #2: 0001-Print-bug-url-for-gcov-dump-help.patch --]
[-- Type: text/x-patch, Size: 674 bytes --]
Print bug url for gcov-dump --help
2017-03-17 Tom de Vries <tom@codesourcery.com>
* gcov-dump.c (print_usage): Print bug_report_url.
---
gcc/gcov-dump.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/gcov-dump.c b/gcc/gcov-dump.c
index 3311772..91c4866 100644
--- a/gcc/gcov-dump.c
+++ b/gcc/gcov-dump.c
@@ -136,6 +136,8 @@ print_usage (void)
printf (" -l, --long Dump record contents too\n");
printf (" -p, --positions Dump record positions\n");
printf (" -w, --working-sets Dump working set computed from summary\n");
+ printf ("\nFor bug reporting instructions, please see:\n%s.\n",
+ bug_report_url);
}
static void
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Install gcov-dump.
2017-03-17 11:55 ` Tom de Vries
@ 2017-03-17 12:08 ` Richard Biener
0 siblings, 0 replies; 8+ messages in thread
From: Richard Biener @ 2017-03-17 12:08 UTC (permalink / raw)
To: Tom de Vries; +Cc: Martin Liška, GCC Patches
On Fri, Mar 17, 2017 at 12:54 PM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> On 14/03/17 13:30, Martin Liška wrote:
>>
>> Tested on my local machine that's properly installed.
>>
>> Ready for trunk?
>
>
> I'm guessing there's an invariant that installed tools mention a bug url
> with --help.
>
> Using attached patch, we get:
> ...
> $ gcov-dump --help
> Usage: gcov-dump [OPTION] ... gcovfiles
> Print coverage file contents
> -h, --help Print this help
> -v, --version Print version number
> -l, --long Dump record contents too
> -p, --positions Dump record positions
> -w, --working-sets Dump working set computed from summary
>
> For bug reporting instructions, please see:
> <https://gcc.gnu.org/bugs/>.
> ...
>
> OK for trunk, 5 and 6 branch?
Ok.
Bonus point if you also write the missing gcov-dump.texi (so we get a
manpage as well).
Thanks,
Richard.
> Thanks,
> - Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-03-17 12:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 12:30 [PATCH] Install gcov-dump Martin Liška
2017-03-14 14:16 ` Richard Biener
2017-03-14 17:31 ` Matthias Klose
2017-03-15 10:19 ` Martin Liška
2017-03-15 13:49 ` Richard Biener
2017-03-16 22:45 ` Matthias Klose
2017-03-17 11:55 ` Tom de Vries
2017-03-17 12:08 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).