From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7132 invoked by alias); 6 May 2011 02:46:33 -0000 Received: (qmail 7123 invoked by uid 22791); 6 May 2011 02:46:33 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 06 May 2011 02:46:19 +0000 Received: (qmail 70572 invoked by uid 20157); 6 May 2011 02:46:18 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 6 May 2011 02:46:18 -0000 Date: Fri, 06 May 2011 04:50:00 -0000 From: Hans-Peter Nilsson To: Richard Guenther cc: Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Cleanup expand_shift In-Reply-To: Message-ID: References: <201105041732.49116.ebotcazou@adacore.com> <201105041805.43662.ebotcazou@adacore.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00482.txt.bz2 On Thu, 5 May 2011, Richard Guenther wrote: > On Wed, 4 May 2011, Richard Guenther wrote: > > On Wed, 4 May 2011, Eric Botcazou wrote: > > Hm. I guess people will scream if something breaks (I can't imagine > > what though). AAAaaarghh! Building cris-elf is now broken. > I have applied the following after re-bootstrapping and testing on > x86_64-unknown-linux-gnu and re-checking the mipsel cross testcase. > > Richard. > > 2011-05-05 Richard Guenther > > * expmed.c (expand_variable_shift): Rename to ... > (expand_shift_1): ... this. Take an expanded shift amount. > For rotates recurse directly not building trees for the shift amount. > (expand_variable_shift): Wrap around expand_shift_1. > (expand_shift): Adjust. PR 48908. brgds, H-P