public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Vladimir Makarov <vmakarov@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFA: another patch to solve PR49154
Date: Thu, 26 May 2011 00:18:00 -0000	[thread overview]
Message-ID: <alpine.BSF.2.00.1105251842120.79489@dair.pair.com> (raw)
In-Reply-To: <4DDD7705.9020003@redhat.com>

On Wed, 25 May 2011, Vladimir Makarov wrote:

> This patch solves http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49154 for CRIS.
> The problem was in that the pressure classes did not contain SRP register and
> the assert failed.

I'm not sure I understand the basic requirement.

> OK to commit?
>
> 2011-05-25  Vladimir Makarov <vmakarov@redhat.com>
>
>         PR rtl-optimization/49154
>         * config/cris/cris.h (reg_class, REG_CLASS_NAMES)
>         (REG_CLASS_CONTENTS, REGNO_REG_CLASS): Add class SRP_REGS.

Can you please suggest an update to the target macro
documentation to reflect the requirement it's currently failing?
To feel ok with this change I need to understand why it's not ok
as is: I can't see the error, just a random change narrowing a
register class that at a glance *should* not be needed.  To wit,
I need to understand why the bug is here and that it's not the
failing assert in IRA that's wrong.

(And thanks for your work, really.  Don't worry about fitting
the update into texinfo format, I can help with that.)

brgds, H-P

  reply	other threads:[~2011-05-25 22:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25 23:43 Vladimir Makarov
2011-05-26  0:18 ` Hans-Peter Nilsson [this message]
2011-05-26  8:34   ` Vladimir Makarov
2011-05-26  9:34     ` Hans-Peter Nilsson
2011-05-26 22:23       ` Vladimir Makarov
2011-05-27  3:59         ` Hans-Peter Nilsson
2011-05-27 13:17           ` Hans-Peter Nilsson
2011-05-28 14:19         ` Hans-Peter Nilsson
2011-05-28 14:53           ` Hans-Peter Nilsson
2011-05-31 16:07           ` Richard Sandiford
     [not found]             ` <alpine.BSF.2.00.1105311648170.8459@dair.pair.com>
     [not found]               ` <87boyir2pm.fsf@firetop.home>
2011-06-02 10:24                 ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.00.1105251842120.79489@dair.pair.com \
    --to=hp@bitrange.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=vmakarov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).