From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18912 invoked by alias); 10 Jun 2011 12:35:55 -0000 Received: (qmail 18794 invoked by uid 22791); 10 Jun 2011 12:35:54 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 10 Jun 2011 12:35:37 +0000 Received: (qmail 61292 invoked by uid 20157); 10 Jun 2011 12:35:37 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 10 Jun 2011 12:35:37 -0000 Date: Fri, 10 Jun 2011 13:08:00 -0000 From: Hans-Peter Nilsson To: Vladimir Makarov cc: gcc-patches@gcc.gnu.org Subject: Re: FORBIDDEN_INC_DEC_CLASSES in ira-costs.c In-Reply-To: Message-ID: References: <4DF0EF39.5020409@redhat.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00834.txt.bz2 On Thu, 9 Jun 2011, Hans-Peter Nilsson wrote: > * ira-costs.c: Remove #ifdefs on dead FORBIDDEN_INC_DEC_CLASSES. > Adjust comments. > * system.h (FORBIDDEN_INC_DEC_CLASSES): Poison. > Index: ira-costs.c > =================================================================== > --- ira-costs.c (revision 174878) > +++ ira-costs.c (working copy) Oops; I spotted a missing comment update. Please replace these hunks: > @@ -1685,9 +1651,6 @@ find_costs_and_classes (FILE *dump_file) > /* Ignore classes that are too small for this operand or > invalid for an operand that was auto-incremented. */ > if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] > -#ifdef FORBIDDEN_INC_DEC_CLASSES > - || (inc_dec_p && forbidden_inc_dec_class[rclass]) > -#endif > #ifdef CANNOT_CHANGE_MODE_CLASS > || invalid_mode_change_p (i, (enum reg_class) rclass) > #endif > @@ -1764,9 +1727,6 @@ find_costs_and_classes (FILE *dump_file) > operand or invalid for an operand that was > auto-incremented. */ > if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] > -#ifdef FORBIDDEN_INC_DEC_CLASSES > - || (inc_dec_p && forbidden_inc_dec_class[rclass]) > -#endif > #ifdef CANNOT_CHANGE_MODE_CLASS > || invalid_mode_change_p (i, (enum reg_class) rclass) > #endif with these: @@ -1682,12 +1648,9 @@ find_costs_and_classes (FILE *dump_file) for (k = 0; k < cost_classes_ptr->num; k++) { rclass = cost_classes[k]; - /* Ignore classes that are too small for this operand or - invalid for an operand that was auto-incremented. */ + /* Ignore classes that are too small or invalid for this + operand. */ if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] -#ifdef FORBIDDEN_INC_DEC_CLASSES - || (inc_dec_p && forbidden_inc_dec_class[rclass]) -#endif #ifdef CANNOT_CHANGE_MODE_CLASS || invalid_mode_change_p (i, (enum reg_class) rclass) #endif @@ -1760,13 +1723,9 @@ find_costs_and_classes (FILE *dump_file) rclass = cost_classes[k]; if (! ira_class_subset_p[rclass][regno_aclass[i]]) continue; - /* Ignore classes that are too small for this - operand or invalid for an operand that was - auto-incremented. */ + /* Ignore classes that are too small or invalid + for this operand. */ if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] -#ifdef FORBIDDEN_INC_DEC_CLASSES - || (inc_dec_p && forbidden_inc_dec_class[rclass]) -#endif #ifdef CANNOT_CHANGE_MODE_CLASS || invalid_mode_change_p (i, (enum reg_class) rclass) #endif brgds, H-P