From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27950 invoked by alias); 22 Jun 2011 21:40:01 -0000 Received: (qmail 27933 invoked by uid 22791); 22 Jun 2011 21:40:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Wed, 22 Jun 2011 21:39:47 +0000 Received: (qmail 51367 invoked by uid 20157); 22 Jun 2011 21:39:46 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 22 Jun 2011 21:39:46 -0000 Date: Wed, 22 Jun 2011 21:54:00 -0000 From: Hans-Peter Nilsson To: Jan Hubicka cc: gcc-patches@gcc.gnu.org Subject: Re: Cgraph alias reorg 15/14 (New infrastructure for same body aliases) In-Reply-To: <20110619125142.GA22865@kam.mff.cuni.cz> Message-ID: References: <20110611125552.GA25068@kam.mff.cuni.cz> <20110619124502.GA1199@kam.mff.cuni.cz> <20110619125142.GA22865@kam.mff.cuni.cz> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01720.txt.bz2 On Sun, 19 Jun 2011, Jan Hubicka wrote: > > > On Sat, 11 Jun 2011, Jan Hubicka wrote: > > > > > > > Hi, > > > > this patch complettes the same body alias rework by removing the old same body > > > > alias code and adding new representation. Same body aliases are now separate > > > > function nodes that have IPA_REF_ALIAS reference to the node they are alias of. > > > > > > > > I am still getting one failure: > > > > FAIL: g++.dg/torture/pr43879-1_1.C > > > > > > > > It tests IPA PTA in presence of same body aliases. I honestly have no idea > > > > what is wrong there. I decided to go ahead with the patch anyway, given the > > > > current state of affair of aliases and IPA-PTA. Hope Richard will help me > > > > fixing this on Monday. > > > > > > Still there, see again PR49373. Anything better than a xfail in the works? > > > > Yes, we discussed the problem with Richi and the issue is that ipa-pta gets > > confused by inliner redirecting edge from alias to the real inline clone. > > The proper fix is to teach passmanager to do small ipa passes before final > > compilation. I am currently at the GCC gathering, so I plan to implement > > this day after tomorrow after returning. > But for sure we can xfail it. Ok, done: PR middle-end/49373 * g++.dg/torture/pr43879-1_1.C: Xfail for -O1 and above, except -flto. Index: g++.dg/torture/pr43879-1_1.C =================================================================== --- g++.dg/torture/pr43879-1_1.C (revision 174961) +++ g++.dg/torture/pr43879-1_1.C (working copy) @@ -1,6 +1,7 @@ /* { dg-do run } */ /* { dg-options "-fipa-pta" } */ /* { dg-additional-sources "pr43879-1_0.C" } */ +/* { dg-xfail-run-if "PR49373" { *-*-* } { -O1 -O2 -O3 -Os } { -flto } } */ struct A { int *i; brgds, H-P