From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-330282-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 7771 invoked by alias); 29 Oct 2012 14:55:56 -0000
Received: (qmail 7752 invoked by uid 22791); 29 Oct 2012 14:55:55 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49)    by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Mon, 29 Oct 2012 14:55:48 +0000
Received: (qmail 57472 invoked by uid 20157); 29 Oct 2012 14:55:47 -0000
Received: from localhost (sendmail-bs@127.0.0.1)  by localhost with SMTP; 29 Oct 2012 14:55:47 -0000
Date: Mon, 29 Oct 2012 15:15:00 -0000
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Dodji Seketeli <dodji@redhat.com>
cc: Jakub Jelinek <jakub@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>,     Diego Novillo <dnovillo@google.com>,     Xinliang David Li <davidxl@google.com>, Wei Mi <wmi@google.com>
Subject: Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls
In-Reply-To: <87bofr6h2c.fsf@redhat.com>
Message-ID: <alpine.BSF.2.00.1210291049550.55046@dair.pair.com>
References: <87liex8hjt.fsf@redhat.com> <8762618ha6.fsf@redhat.com> <20121023160323.GU1752@tucnak.redhat.com> <87bofr6h2c.fsf@redhat.com>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-10/txt/msg02609.txt.bz2

On Wed, 24 Oct 2012, Dodji Seketeli wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
> > On Tue, Oct 23, 2012 at 03:11:29PM +0200, Dodji Seketeli wrote:
> > > 	* asan.c (insert_if_then_before_iter)
> > > 	(instrument_mem_region_access)
> > > 	(maybe_instrument_builtin_call, maybe_instrument_call): New static
> >
> > Why not just write it:
> > 	* asan.c (insert_if_then_before_iter, instrument_mem_region_access,
> > 	maybe_instrument_builtin_call, maybe_instrument_call): New static
> > ?
>
> It's emacs that formats it like that automatically.  I am not sure how
> to teach him otherwise.  I have fixed this as you want by doing it "by
> hand".

JFTR, the emacs-formatted-version *is* the correct one, at least
when going by the GNU coding standard.  Maybe something about
being eager to balance parentheses as early as possible. :)
But, I'll keep formatting it like that myself until someone
updates the GCC coding standard.  Hint, like.

brgds, H-P