public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: gcc-patches@gcc.gnu.org
Subject: Committed: handle negative numbers in gcc-gdb-test.exp
Date: Sat, 24 Nov 2012 09:41:00 -0000	[thread overview]
Message-ID: <alpine.BSF.2.02.1211240440010.50510@dair.pair.com> (raw)

Without this, I got weird ERRORs and those Tcl backtraces you come
to hate, instead of the expected FAILs.  Committed as obvious after
running a failing guality test and obvserving the intended change.
(Well ok, *adding an explanatory comment* is apparently not obvious,
but I'll take that liberty...)

testsuite:
	* lib/gcc-gdb-test.exp (gdb-test): Pass -- as first argument
	to to send_log.

Index: gcc/testsuite/lib/gcc-gdb-test.exp
===================================================================
--- gcc/testsuite/lib/gcc-gdb-test.exp	(revision 192677)
+++ gcc/testsuite/lib/gcc-gdb-test.exp	(working copy)
@@ -74,7 +74,9 @@ proc gdb-test { args } {
 	    if { $first == $second } {
 		pass "$testname"
 	    } else {
-		send_log "$first != $second\n"
+		# We need the -- to disambiguate $first from an option,
+		# as it may be negative.
+		send_log -- "$first != $second\n"
 		fail "$testname"
 	    }
 	    remote_close target

brgds, H-P

                 reply	other threads:[~2012-11-24  9:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.02.1211240440010.50510@dair.pair.com \
    --to=hp@bitrange.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).