* Committed: handle negative numbers in gcc-gdb-test.exp
@ 2012-11-24 9:41 Hans-Peter Nilsson
0 siblings, 0 replies; only message in thread
From: Hans-Peter Nilsson @ 2012-11-24 9:41 UTC (permalink / raw)
To: gcc-patches
Without this, I got weird ERRORs and those Tcl backtraces you come
to hate, instead of the expected FAILs. Committed as obvious after
running a failing guality test and obvserving the intended change.
(Well ok, *adding an explanatory comment* is apparently not obvious,
but I'll take that liberty...)
testsuite:
* lib/gcc-gdb-test.exp (gdb-test): Pass -- as first argument
to to send_log.
Index: gcc/testsuite/lib/gcc-gdb-test.exp
===================================================================
--- gcc/testsuite/lib/gcc-gdb-test.exp (revision 192677)
+++ gcc/testsuite/lib/gcc-gdb-test.exp (working copy)
@@ -74,7 +74,9 @@ proc gdb-test { args } {
if { $first == $second } {
pass "$testname"
} else {
- send_log "$first != $second\n"
+ # We need the -- to disambiguate $first from an option,
+ # as it may be negative.
+ send_log -- "$first != $second\n"
fail "$testname"
}
remote_close target
brgds, H-P
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-11-24 9:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-24 9:41 Committed: handle negative numbers in gcc-gdb-test.exp Hans-Peter Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).