From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-391530-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 7566 invoked by alias); 9 Feb 2015 13:18:28 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 7531 invoked by uid 89); 9 Feb 2015 13:18:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 3 recipients
X-HELO: arjuna.pair.com
Received: from arjuna.pair.com (HELO arjuna.pair.com) (209.68.5.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Feb 2015 13:18:26 +0000
Received: by arjuna.pair.com (Postfix, from userid 3006)	id 09B348A205; Mon,  9 Feb 2015 08:18:23 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])	by arjuna.pair.com (Postfix) with ESMTP id F34198A203;	Mon,  9 Feb 2015 08:18:23 -0500 (EST)
Date: Mon, 09 Feb 2015 13:18:00 -0000
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Matthew Wahab <matthew.wahab@arm.com>
cc: Jonathan Wakely <jwakely.gcc@gmail.com>,     gcc-patches <gcc-patches@gcc.gnu.org>, libstdc++ <libstdc++@gcc.gnu.org>,     hp@gcc.gnu.org
Subject: Re: [PATCH][libstdc++][Testsuite] isctype test fails for newlib.
In-Reply-To: <54D8992B.6060707@arm.com>
Message-ID: <alpine.BSF.2.02.1502090812040.67721@arjuna.pair.com>
References: <54CF9C84.4020706@arm.com> <54CFA31F.9020601@oracle.com> <CAH6eHdQNytx0NCcZEPUBorenk+f=8BE86BSGiJ7=FpXZFYuL3A@mail.gmail.com> <54D0A034.1040306@arm.com> <54D0A291.4010702@oracle.com> <54D0A5B1.2000806@arm.com> <CAH6eHdT2O7rqKPG+auYPPeRmEZsorteub3vgazHpnti3DVdapQ@mail.gmail.com> <54D8992B.6060707@arm.com>
User-Agent: Alpine 2.02 (BSF 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
X-SW-Source: 2015-02/txt/msg00533.txt.bz2

On Mon, 9 Feb 2015, Matthew Wahab wrote:
> On 07/02/15 00:11, Jonathan Wakely wrote:
> > Any idea why HP still sees the tests fail? See comment 8 at
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64467#c8
>
> It looks like he's found the problem: that _NEWLIB_ is a recent addition that
> isn't in the version he's using. I'll try replacing _NEWLIB_ with
> _NEWLIB_VERSION_ as suggested.

(Careful with that macro spelling, if nothing else.)

Better to use existing mechanisms and stop playing with
target-related macros.  Add this at the top (see other
placements of dg-options) and replace "#if defined (__NEWLIB__)"
with "#ifdef NEWLINE_IN_CLASS_BLANK":

// { dg-options "-DNEWLINE_IN_CLASS_BLANK" { target newlib } }

brgds, H-P