From: Hans-Peter Nilsson <hp@bitrange.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Richard Henderson <rth@redhat.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [libstdc++/65033] Give alignment info to libatomic
Date: Fri, 03 Apr 2015 03:04:00 -0000 [thread overview]
Message-ID: <alpine.BSF.2.02.1504022301400.40679@arjuna.pair.com> (raw)
In-Reply-To: <20150325162244.GF9755@redhat.com>
On Wed, 25 Mar 2015, Jonathan Wakely wrote:
> I've convinced myself that Richard's patch is correct in all cases,
> but I think we also want this patch, to fix PR62259 and PR65147.
>
> For the generic std::atomic<T> (i.e. not the integral or pointer
> specializations) we should increase the alignment of atomic types that
> have the same size as one of the standard integral types. This should
> be consistent with what the C front end does for _Atomic, based on
> what Joseph told me on IRC:
Wrong.
> <jsm28> jwakely: _Atomic aligns 1/2/4/8/16-byte types the same as
> integer types of that size.
No it doesn't! It's "same or higher as".
> <jsm28> (Which may not be alignment = size, depending on the
> architecture.)
>
> Ideally we'd use an attribute like Andrew describes at
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62259#c4 but that's not
> going to happen for GCC 5, so this just looks for an integral type of
> the same size and uses its alignment.
>
> Tested x86_64-linux, powerpc64le-linux.
>
> I'll wait for RM approval for this and Richard's patch (which is OK
> from a libstdc++ perspective).
>
brgds, H-P
next prev parent reply other threads:[~2015-04-03 3:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 21:23 Richard Henderson
2015-02-18 12:15 ` Jonathan Wakely
2015-03-25 16:22 ` Jonathan Wakely
2015-03-25 18:36 ` Richard Henderson
2015-03-25 18:49 ` Jonathan Wakely
2015-03-25 19:04 ` Richard Henderson
2015-03-26 13:21 ` Jonathan Wakely
2015-03-31 13:41 ` Jonathan Wakely
2015-03-31 14:54 ` Richard Henderson
2015-03-31 15:03 ` Jonathan Wakely
2015-03-31 15:13 ` Richard Henderson
2015-03-31 15:41 ` Jonathan Wakely
2015-04-06 22:59 ` Hans-Peter Nilsson
2015-04-13 4:45 ` patch fix issue 1 with "[libstdc++/65033] Give alignment info to libatomic" Hans-Peter Nilsson
2015-04-13 11:59 ` Jonathan Wakely
2015-04-13 5:59 ` Issue 2 " Hans-Peter Nilsson
2015-04-13 17:53 ` Joseph Myers
2015-03-25 18:39 ` [libstdc++/65033] Give alignment info to libatomic Richard Henderson
2015-04-03 3:04 ` Hans-Peter Nilsson [this message]
2015-03-26 11:54 ` Jonathan Wakely
2015-04-03 3:57 ` Hans-Peter Nilsson
2015-04-03 9:25 ` Hans-Peter Nilsson
2015-04-03 14:13 ` Jonathan Wakely
2015-04-03 19:13 ` Richard Henderson
2015-04-07 13:14 ` Jonathan Wakely
2015-04-09 11:17 ` Jonathan Wakely
2015-04-06 1:07 ` Hans-Peter Nilsson
2015-04-07 9:45 ` Jonathan Wakely
2015-04-07 10:52 ` Hans-Peter Nilsson
2015-04-07 13:12 ` Jonathan Wakely
2015-04-07 14:51 ` Hans-Peter Nilsson
2015-04-07 15:06 ` Jonathan Wakely
2015-04-08 3:58 ` Hans-Peter Nilsson
2015-04-08 9:35 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.02.1504022301400.40679@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).