From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29633 invoked by alias); 18 Jun 2016 23:49:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29611 invoked by uid 89); 18 Jun 2016 23:49:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=hp, prominent, HP, Hx-languages-length:1680 X-HELO: arjuna.pair.com Received: from arjuna.pair.com (HELO arjuna.pair.com) (209.68.5.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 18 Jun 2016 23:49:16 +0000 Received: by arjuna.pair.com (Postfix, from userid 3006) id E678B8A1E9; Sat, 18 Jun 2016 19:49:10 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id E5DFB8A05F; Sat, 18 Jun 2016 19:49:10 -0400 (EDT) Date: Sat, 18 Jun 2016 23:49:00 -0000 From: Hans-Peter Nilsson To: Bernhard Reutner-Fischer cc: gcc-patches@gcc.gnu.org, Mike Stump , Rainer Orth Subject: Re: [PATCH] PR52665 do not let .ident confuse assembler scan tests In-Reply-To: <1466278273-7014-1-git-send-email-rep.dot.nop@gmail.com> Message-ID: References: <1466278273-7014-1-git-send-email-rep.dot.nop@gmail.com> User-Agent: Alpine 2.02 (BSF 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg01358.txt.bz2 On Sat, 18 Jun 2016, Bernhard Reutner-Fischer wrote: > A branch with a name matching scan-assembler pattern triggers > inappropriate FAIL. > > E.g. branch fixups-testsuite and > - gcc.target/i386/pr65871-?.c (scan-assembler-not "test") > - gcc.target/i386/pr41442.c (scan-assembler-times "test|cmp" 2) > etc. > > This is a recurring problem as can be seen by some -fno-ident additions > by commits from e.g. Michael Meissner over the years: builtins-58.c, > powerpc/pr46728-?.c > > The patch below adds -fno-ident if a testcase contains one of > scan-assembler, scan-assembler-not or scan-assembler-times. This reminds me of a related but not opposing idea that I have never acted on (besides bouncing it off a global maintainer quite some time ago, with a positive response), to make common identifier-like and filename-like strings invalid for use in scan-assembler; there'd have to be a meta-character such as whitespace. It would help for "test" but admittedly not for "test|cmp" given e.g. an objdir named "/tmp/mytest/gccmp/nop1". Then there'd be an error thrown for such test-cases, alerting the author (well, hopefully) that the test-case is in error, and a comment in the scan-assembler code would make it prominent that there'd have to be a whitespace or meta-like character (i.e. [^-a-zA-Z_\.]) included in the string. Yes, I know whitespace can be included in filenames and that's regularly done at least on some systems, but I bet you really get into problems trying that for srcdir or objdir in a gcc build. Sorry, still not going to act on it for now, but feel free if so inclined. brgds, H-P