From: Hans-Peter Nilsson <hp@bitrange.com>
To: FX <fxcoudert@gmail.com>
Cc: gcc patches <gcc-patches@gcc.gnu.org>, libstdc++@gcc.gnu.org
Subject: Re: [libstdc++, patch] Fix build on APFS file system
Date: Wed, 18 Oct 2017 23:20:00 -0000 [thread overview]
Message-ID: <alpine.BSF.2.02.1710181835130.7798@arjuna.pair.com> (raw)
In-Reply-To: <1148963B-29B1-48D5-B295-15A5593AC4B9@gmail.com>
On Wed, 18 Oct 2017, FX wrote:
> Parallel builds of libstdc++ on APFS filesystem (with 1 ns granularity) on macOS 10.13 often fail (failure rate for ?make -j2? to ?make -j8? is about 60% from my own builds and results reported by others): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81797
> This is reproducible with several versions of GNU make.
>
> Changing libstdc++?s makefile to mark install-headers with .NOTPARALLEL fixes the issue. We've carried that patch in Homebrew (https://brew.sh) for a few months now, and have had no report of build issues since then.
>
> Bootstrapped and regtested on x86_64-apple-darwin17 (as well as other platforms). OK to commit?
Maybe moot now, but .NOTPARALLEL doesn't work the way you imply
in the patch. From TFM of GNU Make 3.81 and 4: "Any
prerequisites on this target are ignored."
To wit, it seems you'd get the effect, but for *every target* in
this Makefile. (If I were you and the patch is still proposed,
I'd remove the unused target and add a comment on the intent.)
Assuming the documentation and my reading is correct.
brgds, H-P
next prev parent reply other threads:[~2017-10-18 22:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 15:08 FX
2017-10-18 20:59 ` Petr Ovtchenkov
2017-10-18 21:05 ` FX
2017-10-18 21:17 ` Jonathan Wakely
2017-10-18 22:22 ` FX
2017-10-19 8:43 ` Richard Biener
2017-10-19 8:49 ` FX
2017-10-19 10:28 ` Petr Ovtchenkov
2017-10-19 0:28 ` Jonathan Wakely
2017-10-18 23:20 ` Hans-Peter Nilsson [this message]
2017-10-19 1:11 ` Jonathan Wakely
2017-10-23 17:44 ` Mike Stump
2017-10-23 17:55 ` FX
2017-10-23 18:02 ` Jonathan Wakely
2017-10-24 9:08 ` FX
2017-10-24 13:50 ` Jonathan Wakely
2017-10-24 14:19 ` FX
[not found] ` <1B1E8CBD-E34E-415A-A5D7-FB3AACA72749@gmail.com>
2017-10-24 15:06 ` Jonathan Wakely
2017-10-24 15:22 ` FX
2017-10-24 15:47 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.02.1710181835130.7798@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).