From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117480 invoked by alias); 8 Feb 2018 23:10:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117471 invoked by uid 89); 8 Feb 2018 23:10:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=hp, HP, umm X-HELO: arjuna.pair.com Received: from arjuna.pair.com (HELO arjuna.pair.com) (209.68.5.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Feb 2018 23:10:33 +0000 Received: by arjuna.pair.com (Postfix, from userid 3006) id DC6278A528; Thu, 8 Feb 2018 18:10:31 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id DBF468A519; Thu, 8 Feb 2018 18:10:31 -0500 (EST) Date: Thu, 08 Feb 2018 23:10:00 -0000 From: Hans-Peter Nilsson To: Segher Boessenkool cc: Michael Meissner , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PowerPC PR target/84154, fix floating point to small integer conversion regression In-Reply-To: <20180207224113.GH21977@gate.crashing.org> Message-ID: References: <20180201193116.GA15164@ibm-tiger.the-meissners.org> <20180205115724.GQ21977@gate.crashing.org> <20180205125457.GA20319@ibm-tiger.the-meissners.org> <20180205140131.GT21977@gate.crashing.org> <20180205225751.GA11436@ibm-tiger.the-meissners.org> <20180206171521.GB21977@gate.crashing.org> <20180206213407.GA26958@ibm-tiger.the-meissners.org> <20180207224113.GH21977@gate.crashing.org> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00472.txt.bz2 On Wed, 7 Feb 2018, Segher Boessenkool wrote: > Hi Mike, > > On Tue, Feb 06, 2018 at 04:34:08PM -0500, Michael Meissner wrote: > > Here is the patch reworked. It bootstraps on both little/big endian power8, > > and all of the tests run. Can I install this into trunk now, and into GCC 7 > > after a soak period (along with the previous patch)? > > > +;; If have ISA 3.0, QI/HImode values can go in both VSX registers and GPR > > "If we have"? > > > + [(set (match_operand:QHSI 0 "memory_operand" "=Z") > > + (any_fix:QHSI (match_operand:SFDF 1 "gpc_reg_operand" "wa"))) > > + (clobber (match_scratch:SI 2 "=wa"))] > > + "((mode == SImode && TARGET_P8_VECTOR) > > + || (mode != SImode && TARGET_P9_VECTOR))" > > This is the same as > > "(mode == SImode && TARGET_P8_VECTOR) || TARGET_P9_VECTOR" Umm, sorry for chiming in here with zero rs6000 knowledge and I might be missing something trivial but...what wouldn't that misfire for "mode == SImode && ! TARGET_P8_VECTOR && TARGET_P9_VECTOR" ? (Is that invalid or not applicable or don't care or something?) brgds, H-P