public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: kamlesh kumar <kamleshbhalui@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][PPC64] [PR88877]
Date: Tue, 24 Mar 2020 13:13:12 -0400 (EDT)	[thread overview]
Message-ID: <alpine.BSF.2.20.16.2003241307470.50608@arjuna.pair.com> (raw)
In-Reply-To: <CABKRkgixAzRfwaPL1BAbvx+bkiCs5WwdABvbrWq-5=WOcrtfvA@mail.gmail.com>

Please excuse some cheap points:

On Mon, 23 Mar 2020, kamlesh kumar via Gcc-patches wrote:

> Attached patch fixes.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877.
> ChangeLog Entry.
>
> 2020-03-23  Kamlesh Kumar  <kamleshbhalui@gmail.com>
>
>         * rtl.h : Defined Tuple for bundling rtx, mode and
> unsignedness default as 0
>         Added Extra argument (unsignedp) in emit_library_call and
> emit_library_call_value.

Formatting issue: "." ends sentences, but you should not
terminate the line.  No space before ":".  See other entries.

>         * except.c : Likewise.
>         * explow.c : Likewise.
>         * expmed.c : Likewise.
>         * expr.c : Likewise.
>         * optabs.c : Likewise.
>         * asan.c : Likewise.
>         * builtins.c : Likewise.
>         * calls.c : Likewise.
>         * cfgexpand.c : Likewise.
>         * config/aarch64/aarch64.c : Likewise.
>         * config/aarch64/aarch64.h : Likewise.
>         * config/aarch64/atomics.md : Likewise.
>         * config/alpha/alpha.c : Likewise.
>         * config/arc/arc.c : Likewise.

...

The new argument is default 0, so make use of that: do not patch
all those files where 0 is fine.

brgds, H-P

  reply	other threads:[~2020-03-24 17:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 14:46 kamlesh kumar
2020-03-24 17:13 ` Hans-Peter Nilsson [this message]
2020-03-24 17:24   ` Hans-Peter Nilsson
2020-03-24 17:54     ` kamlesh kumar
2020-04-06  6:16 ` kamlesh kumar
2020-04-06  9:17   ` Richard Biener
2020-04-06  9:28     ` kamlesh kumar
2020-04-08 15:58       ` Jeff Law
2020-05-19 12:02         ` kamlesh kumar
2020-05-22 15:18           ` kamlesh kumar
2020-04-07 21:02   ` Segher Boessenkool
2020-05-23 14:43 ` Segher Boessenkool
2020-05-24 13:33   ` [PATCH v1 1/2][PPC64] [PR88877] Kamlesh Kumar
2020-05-24 16:22     ` Segher Boessenkool
2020-05-25  7:16       ` kamlesh kumar
2020-05-25 16:31         ` Segher Boessenkool
2020-05-25 16:37           ` Richard Biener
2020-05-25 16:43             ` Jakub Jelinek
2020-05-25 16:53               ` Iain Sandoe
2020-06-09 20:29       ` Jeff Law
2020-06-11 23:13         ` Segher Boessenkool
2020-06-13 10:17           ` [PATCH] Defined libcall_arg_t Kamlesh Kumar
2020-06-13 10:47           ` [PATCH v1 1/2][PPC64] [PR88877] kamlesh kumar
2020-05-26 11:42     ` Richard Sandiford
2020-06-13 10:27 ` [PATCH] Defined libcall_arg_t Kamlesh Kumar
2020-06-16  9:04   ` Richard Sandiford
2020-06-16 11:07     ` Kamlesh Kumar
2020-06-16 12:09       ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.20.16.2003241307470.50608@arjuna.pair.com \
    --to=hp@bitrange.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kamleshbhalui@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).