From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 79223385042D for ; Fri, 4 Sep 2020 20:15:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 79223385042D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hp@bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id AD8BC8A0DC; Fri, 4 Sep 2020 16:15:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id AB14E8A081; Fri, 4 Sep 2020 16:15:00 -0400 (EDT) Date: Fri, 4 Sep 2020 16:15:00 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Hu Jiangping cc: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: Re: [PATCH v2] doc: add 'cd' command before 'make check-gcc' command in install.texi In-Reply-To: <20200829113041.4859-1-hujiangping@cn.fujitsu.com> Message-ID: References: <20200829113041.4859-1-hujiangping@cn.fujitsu.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2020 20:15:02 -0000 On Sat, 29 Aug 2020, Hu Jiangping wrote: > This patch add 'cd' command before 'make check-gcc' command > when run the testsuite on selected tests. No, don't do that; those targets work fine from the toplevel too, and then include the language libs. > Richard and I agree it would be good for clarity and > emphasis to have the cd in the example as well, although > the text above the example was trying to restrict that to > objdir/gcc. Aha, I guess you misinterpreted the existing "cd @var{objdir}; make -k check", because I see no /gcc there. Please remove the /gcc from the patch. Some .exp just exist in the gcc dir, but that's not the point of these examples and the extra iteration from the toplevel doesn't take more than a second or two. The bigger risk is missing testing in the target libraries. (Incidentally, while GNU make is required such that "-C objdir" would be equivalent, for newcomers I agree the "cd" is clearer in examples.) brgds, H-P