From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id B34FE39730E4 for ; Wed, 10 Mar 2021 17:11:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B34FE39730E4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hp@bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id 269CF8A548; Wed, 10 Mar 2021 12:11:34 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 25E438A537; Wed, 10 Mar 2021 12:11:34 -0500 (EST) Date: Wed, 10 Mar 2021 12:11:34 -0500 (EST) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Alexandre Oliva cc: gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump Subject: Re: enable sqrt insns for cdce3.c In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1823847789-1039941559-1615396294=:12461" X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NORMAL_HTTP_TO_IP, NUMERIC_HTTP_ADDR, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 17:11:36 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1823847789-1039941559-1615396294=:12461 Content-Type: text/plain; charset=US-ASCII On Wed, 10 Mar 2021, Alexandre Oliva wrote: > > The test expects shrink-wrapping of the fsqrt call, but that will only > occur when there is a usable sqrt insn. > > Arrange for dejagnu to add the options that enable the sqrt insn, if > one is available, and to skip the test otherwise. > > > H-P, this *should* obviate the mmix-specific dg-skip-if. Unfortunately it doesn't. > Would it be > easy for you to confirm that this is the case and, if so, drop it? About as easy as for anyone (this is a compile-test), but no problem. Unfortunately I get, with your patch applied and the dg-skip-if removed: FAIL: gcc.dg/cdce3.c scan-tree-dump cdce "cdce3.c:12: [^\n\r]* function call is shrink-wrapped into error conditions." The dump files and assembly file show no obvious clues to me as to what is supposed to happen; attached. brgds, H-P --1823847789-1039941559-1615396294=:12461 Content-Type: text/plain; charset=US-ASCII; name=cdce3.c.113t.cdce Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=cdce3.c.113t.cdce DQo7OyBGdW5jdGlvbiBmb28gKGZvbywgZnVuY2RlZl9ubz0wLCBkZWNsX3Vp ZD0xNDIxLCBjZ3JhcGhfdWlkPTEsIHN5bWJvbF9vcmRlcj0wKQ0KDQpmbG9h dCBmb28gKGZsb2F0IHgpDQp7DQogIGZsb2F0IF80Ow0KDQogIDxiYiAyPiBb bG9jYWwgY291bnQ6IDEwNzM3NDE4MjRdOg0KICBfNCA9IHNxcnRmICh4XzIo RCkpOw0KICByZXR1cm4gXzQ7DQoNCn0NCg0KDQo= --1823847789-1039941559-1615396294=:12461 Content-Type: text/plain; charset=US-ASCII; name=cdce3.c.244t.optimized Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=cdce3.c.244t.optimized DQo7OyBGdW5jdGlvbiBmb28gKGZvbywgZnVuY2RlZl9ubz0wLCBkZWNsX3Vp ZD0xNDIxLCBjZ3JhcGhfdWlkPTEsIHN5bWJvbF9vcmRlcj0wKQ0KDQpmbG9h dCBmb28gKGZsb2F0IHgpDQp7DQogIGZsb2F0IF80Ow0KDQogIDxiYiAyPiBb bG9jYWwgY291bnQ6IDEwNzM3NDE4MjRdOg0KICBfNCA9IHNxcnRmICh4XzIo RCkpOyBbdGFpbCBjYWxsXQ0KICByZXR1cm4gXzQ7DQoNCn0NCg0KDQo= --1823847789-1039941559-1615396294=:12461 Content-Type: text/plain; charset=US-ASCII; name=cdce3.s Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=cdce3.s IyAxICJjZGNlMy5jIg0KISBtbWl4YWw6PSA4SCBMT0MgRGF0YV9TZWN0aW9u DQoJLnRleHQgISBtbWl4YWw6PSA5SCBMT0MgOEINCgkucDJhbGlnbiAyDQoJ TE9DIEArKDQtQCkmMw0KCS5nbG9iYWwgZm9vDQpmb28JSVMgQA0KCUdFVCAk MSxySg0KCVNFVCAkMywkMA0KCVBVU0hKICQyLHNxcnRmDQoJUFVUIHJKLCQx DQoJU0VUICQwLCQyDQoJUE9QIDEsMA0KDQoJLmlkZW50CSJHQ0M6IChHTlUp IDExLjAuMSAyMDIxMDMwOSAoZXhwZXJpbWVudGFsKSBbbWFzdGVyIHJldmlz aW9uIDA0NTVjZDc2YjY4NzowZWQ2NjU3MWIxZDk6NjNkNzRmZWQ0NTY2ZjFk ZTU4M2MzNjhlY2I5ZTJmYzQyM2ZiMWM4N10iDQoJLmRhdGEgISBtbWl4YWw6 PSA4SCBMT0MgOUINCg== --1823847789-1039941559-1615396294=:12461--