From: Hans-Peter Nilsson <hp@bitrange.com>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: gcc-patches@gcc.gnu.org, Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH] PR middle-end/103059: reload: Also accept ASHIFT with indexed addressing
Date: Sun, 7 Nov 2021 23:15:32 -0500 (EST) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2111072250510.68022@arjuna.pair.com> (raw)
In-Reply-To: <alpine.DEB.2.20.2111062018550.8821@tpp.orcam.me.uk>
On Sun, 7 Nov 2021, Maciej W. Rozycki wrote:
> On Fri, 5 Nov 2021, Hans-Peter Nilsson wrote:
>
> > > I was trying to chase another target I could use to regression-test this
> > > with that does do scaled indexed addressing while still using old reload.
> > > The i386 port would be a good candidate, but it has switched to LRA long
> > > ago with no option to use old reload, and I think there would be little
> > > point in adding one just for the sake of such verification. Do we have
> > > any other port actually that could be affected by this change?
> >
> > That'd be cris-elf.
>
> Good to know, thanks!
>
> How do I run regression-testing with this target however? I can see QEMU
> support upstream, even for user-mode Linux, which would be the easiest to
> run (sadly toolchain support for CRIS/Linux was removed a while ago as was
> the Linux kernel port; at one point I even considered getting myself a
> CRIS development board as an alternative RISC platform that would Linux,
> but concluded that it was too expensive for the features it offered), but
> for a bare metal environment both a C library (newlib?) and then a
> specific board support package is required.
Classic "bare-metal" whatever-elf testing should not be a
stranger: sim and binutils support are in place in the official
binutils+gdb git, as is newlib in that git and since many
dejagnu releases a cris-sim.exp baseboard file. Just build and
install binutils and sim for cris-elf (can probable be done at
the same time/same builds from a binutils-and-gdb checkout, but
separate builds are sometimes necessary) then build and test gcc
from a combined-source-tree containing newlib and gcc.
(Instructions for combining trees may be salvaged from the
rottening https://gcc.gnu.org/simtest-howto.html but actually I
roll tarballs and untar gcc over an (untarred) newlib tree.)
I don't have a baseboard file for QEMU, sorry.
> Or may I ask you to put this patch through testing with your environment?
Where's the fun in that? :)
(I thought you'd use 6cb68940dcf9 and do the same for VAX.)
> > Your proposed patch reminded me of 6cb68940dcf9; giving reload a
> > reload-specific insn_and_split pattern to play with, matching
> > "mult" outside of a mem. I *guess* that's the CRIS-specific
> > replacement to c605a8bf9270.
>
> Possibly, except for the missing reload bits making it incomplete.
No, my thinking was that it wouldn't be needed. But, I didn't
have a close look and maybe the problem isn't exactly the same
or VAX has additional caveats. Also, that reload-pacifying
pattern *is* a target-specific workaround for a reload bug, but
a risk-free one for other targets.
brgds, H-P
PS. I'll fire up a round with that patch "tomorrow". Film at 11.
next prev parent reply other threads:[~2021-11-08 4:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 13:53 Maciej W. Rozycki
2021-11-04 18:12 ` Jeff Law
2021-11-04 21:04 ` Maciej W. Rozycki
2021-11-04 23:47 ` Jeff Law
2021-11-05 0:18 ` Maciej W. Rozycki
2021-11-09 0:26 ` Jeff Law
2021-11-10 16:41 ` Maciej W. Rozycki
2021-11-23 19:04 ` Jeff Law
2021-11-24 13:20 ` Maciej W. Rozycki
2021-11-24 13:25 ` Richard Biener
2021-11-24 13:38 ` Maciej W. Rozycki
2021-11-06 2:38 ` Hans-Peter Nilsson
2021-11-07 21:22 ` Maciej W. Rozycki
2021-11-08 4:15 ` Hans-Peter Nilsson [this message]
2021-11-08 10:00 ` Maciej W. Rozycki
2021-11-12 23:22 ` Hans-Peter Nilsson
2021-11-07 21:24 ` Maciej W. Rozycki
2021-11-09 11:59 ` Maciej W. Rozycki
2021-11-08 19:55 ` Hans-Peter Nilsson
2021-11-09 12:11 ` Maciej W. Rozycki
2021-11-08 19:55 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2111072250510.68022@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@embecosm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).