From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 1F8583858D33 for ; Wed, 11 Jan 2023 00:53:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F8583858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id 89ABF8A658; Tue, 10 Jan 2023 19:53:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 890528A547; Tue, 10 Jan 2023 19:53:07 -0500 (EST) Date: Tue, 10 Jan 2023 19:53:07 -0500 (EST) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: YunQiang Su cc: gcc-patches@gcc.gnu.org, aurelien@aurel32.net, adhemerval.zanella@linaro.org, jiaxun.yang@flygoat.com, macro@orcam.me.uk, syq@debian.org, jakub@redhat.com, dodji@redhat.com, kcc@google.com, dvyukov@google.com Subject: Re: [PATCH] libsanitizer/mips: always build with largefile support In-Reply-To: <20230106103632.3951217-1-yunqiang.su@cipunited.com> Message-ID: References: <20230106103632.3951217-1-yunqiang.su@cipunited.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.10 on 209.68.5.131 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 6 Jan 2023, YunQiang Su wrote: > -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 is always used for mips > when build libsanitizer in LLVM. Thus > FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 176 : 160, 216); > instead of > FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216); > in sanitizer_platform_limits_posix.h. > > To keep sync with LLVM and to make the code simple, we use the > largefile options always. > > libsanitizer/ > * configure.ac: set -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 > always for mips*. > * configure: Regenerate. Hm, yes, that might be the most pragmatic way to solve the mips stat-size issue... But shouldn't then largefile-options also be forced when libsanitizer is *used*? IOW, mips*-linux gcc-options be tweaked to include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 conditional on sanitizer-options? brgds, H-P