public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Jiawei <jiawei@iscas.ac.cn>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@sifive.com,
	palmer@dabbelt.com,  christoph.muellner@vrull.eu,
	wuwei2016@iscas.ac.cn
Subject: Re: [PATCH v2] RISC-V: Add Z*inx imcompatible check in gcc.
Date: Mon, 3 Apr 2023 21:46:25 -0400 (EDT)	[thread overview]
Message-ID: <alpine.BSF.2.20.16.2304032141440.82135@arjuna.pair.com> (raw)
In-Reply-To: <20230328142302.3824535-1-jiawei@iscas.ac.cn>

On Tue, 28 Mar 2023, Jiawei wrote:

> +  // Zfinx is conflict with float extensions.
> +  if (TARGET_ZFINX && TARGET_HARD_FLOAT)
> +    error ("z*inx is conflict with float extensions");
> +

While I'm not a native English speaker, "is conflict with" 
doesn't sound grammatically correct.  Perhaps "conflicts with" 
or "is in conflict with"?

brgds, H-P

  parent reply	other threads:[~2023-04-04  1:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 14:23 Jiawei
2023-03-28 14:30 ` Kito Cheng
2023-04-04  1:46 ` Hans-Peter Nilsson [this message]
2023-04-05  1:30   ` Jeff Law
2023-04-06  2:56     ` jiawei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.20.16.2304032141440.82135@arjuna.pair.com \
    --to=hp@bitrange.com \
    --cc=christoph.muellner@vrull.eu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jiawei@iscas.ac.cn \
    --cc=kito.cheng@sifive.com \
    --cc=palmer@dabbelt.com \
    --cc=wuwei2016@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).